Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Russian Translation to RSR #138

Closed
adriancollier opened this issue Jan 10, 2013 · 7 comments
Closed

Add Russian Translation to RSR #138

adriancollier opened this issue Jan 10, 2013 · 7 comments

Comments

@adriancollier
Copy link
Contributor

Provision of manual translation of the Partner Sites UI to Russian via the Transifex system.

With the following steps/stages:

  • Via Transifex provide the Russian versions of the string-base
  • Add Russian strings to RSR
  • Add Russian to Interface in RSR
  • Deploy to accessible test server
  • Confirm quality of translations via translator
  • Make any modifications and suggestion and redeploy
  • Confirm acceptance of new translation options
@ghost ghost assigned adriancollier Jan 10, 2013
adriancollier pushed a commit that referenced this issue Jan 10, 2013
Adding the po file and the UI changes to templates for the Russian
Translation of RSR.
Still need to have the .mo files to be compiled.
zzgvh added a commit that referenced this issue Jan 10, 2013
Remove *.mo from .gitignore
@bjelkeman
Copy link
Member

Bugs or design issues found with the translation implementation.

Listing page

The Donate button and the Funding heading in Russian becomes very long, as the corresponding russian words are long. This then shows some alignment problems in Funding column on Partner sites project listing page which hasn't been obvious before. Specifically the funding "bar" aligns left rather than being centered.

The column Updated is not translated. (Seems a problem in all languages.)

Page controls, i.e. previous and next, next are not translated (Same problem in all languages.)

Locations are not translated (Country name, Continent etc.) (Same problem in all languages.)

Funding box

Fully funded projects, the russian text is too big to fit in the box.

Should the date have a "r." behind it in russian?

Maps

The controls on the map aren't translated. (Same problem in all languages.)

The map itself is not translated (countries etc.). (Same problem in all languages.)

Project page

The Views box on the Project page has the russian running out of the box.

Organisation page

Organisation type (i.e. Knowledge institution) is not translated.

Address is not translated. (Same problem in all languages.)

Widget page

Widget description just above the map is not translated. (Same problem in all languages.)

The map on the Widget page has the little man you drop in for street view (probably not a translation problem. Same in all languages.)

Login page

When clicking the updated button, the resulting login page is in english. Seems the link itself on the update button is correct < http://undp.akvotest3.org/ru/project/673/update/ > but you end up on this page < http://undp.akvotest3.org/en/rsr/signin/?next=/ru/project/673/update/ > which has /en/ in the URL.

@adriancollier
Copy link
Contributor Author

Thanks for this feedback Thomas. Some of these items are "On the radar" and some not.

For the "Same problem in all languages" issues, we need to make decisions about what should be done about these - some of them are not trivial solutions - I believe the navigation Previous and Next is one of these.

The templating issues also need to be resolved at a higher level to ensure that any solution works for all languages.

@adriancollier
Copy link
Contributor Author

Items still to be completed:

  • The funding bar should be Centred on the Project Listing page as the longer Russian text brings this out of alignment.
  • The Views Box has text too long to fit. We need to look at anchoring to the right hand side and see how this looks and how it works with all Partnersites.
  • The Updated Column isn't translated currently in any language. We need to fix this.
  • Name and Type Columns on the Organisation Page need to be looked at to determine how much work it would take to include these in the translation effort.
  • Previous and Next Buttons to be translated if possible.
  • Previous and Next Buttons to be hidden when no previous or next page exists.
  • Locations (Countries and Continents) should use the translated strings in the dropdowns.
  • The trunk of the URL does not honour the language of the original page after Sign In - this needs to be resolved.
  • Content missing translation tag in template on Map Widget Collection page - we need to investigate why this isn't being translated.
  • Investigate the options of providing multi-lingual maps and map widgets from Google.

@zzgvh
Copy link
Contributor

zzgvh commented Feb 25, 2013

In the .po file there are a number of translations that have the "fuzzy" comment. This is because they are determined to be somewhat incorrect and the gettext machinery isn't sure if the translation really should be used. There are also a number of fuzzy comments to translations that won't compile since the variables in the source and the translations don't match. All variables in the source have to be used in the translation. The translator can remove the fuzzy comment and thereby verify that the translation is indeed correct and it will then be included when the messages are compiled into the .mo

  • The funding bar should be Centred on the Project Listing page as the longer Russian text brings this out of alignment.
    FIXED
  • The Views Box has text too long to fit. We need to look at anchoring to the right hand side and see how this looks and how it works with all Partnersites.
    FIXED with a small caveat: older browsers that don't support min-width get a slightly narrower box.
  • The Updated Column isn't translated currently in any language. We need to fix this.
    FIXED
  • Name and Type Columns on the Organisation Page need to be looked at to determine how much work it would take to include these in the translation effort.
    FIXED
  • Previous and Next Buttons to be translated if possible.
    After some digging the conclusion is that we could do this, but it would mean creating our own fork of the pagination app and adding translations to it. The code seems to be prepared for translation with {% trans %} tags but there are no .po and .mo files.
  • Previous and Next Buttons to be hidden when no previous or next page exists.
    Same as above, needs forking and hacking.
  • Locations (Countries and Continents) should use the translated strings in the dropdowns.
    That is sorta tricky since those names come from the DB. It's doable I think, but will need some serious hacking.
  • The trunk of the URL does not honour the language of the original page after Sign In - this needs to be resolved.
  • Content missing translation tag in template on Map Widget Collection page - we need to investigate why this isn't being translated.
    See above about fuzzy marked items.
  • Investigate the options of providing multi-lingual maps and map widgets from Google.

zzgvh added a commit that referenced this issue Feb 26, 2013
zzgvh added a commit that referenced this issue Feb 26, 2013
The box showing the number of views for the page doesn't widen as needed
in some browsers leading to text overflow for some translations.
Fix this by replacing width with min-width in the style sheet.
zzgvh added a commit that referenced this issue Feb 26, 2013
When clicking on the button to make a project update the sign-in page
was always in English regardless of chosen UI translation.

Fix this by calling reverse() in the view code instead of using a hard
coded path.
zzgvh added a commit that referenced this issue Feb 26, 2013
The funding amounts are wrapped in blocktrans but the content to be
translated is just the currency and the value. Remove the blocktrans
that only caused trouble.

(Localization of how money is represented should be implemented using
local flavor (django.contrib.localflavor) I believe, if at all.)
zzgvh added a commit that referenced this issue Feb 26, 2013
The funding bar in the Funding column of the partner site home page is
not centered leading to bad alignment when the column is widened in
certain translations.

Fix by setting setting the align attribute on the <td> to center.
zzgvh added a commit that referenced this issue Feb 26, 2013
Since we don't want Google to translate the organisation names I tried
adding a span tag with a notranslate attribute around the org in the
title. This doesn't work however since you cannot have markup in the
title.

I can't see how to solve this without resorting to some javascript
manipulation of the title.
@adriancollier
Copy link
Contributor Author

We have a newly generated po file for the Russain language translations:

https://www.dropbox.com/s/h0nrj32bxfacies/RUSSIAN_django.po

I am not 100% confident that no manual changes have been made to the current file since loading it from Transifex, so I have not replaced the current file yet.

@adriancollier
Copy link
Contributor Author

@kardan do you maybe have some time to add the latest russian po file into develop?

The above link contains the most recent updated file, and I think it just needs to replace the old one (and have those scripts run...)

adriancollier added a commit that referenced this issue Jun 27, 2013
Still need to compile the translation, but here is the latest po file
@adriancollier
Copy link
Contributor Author

@zzgvh could you compile the new po file please? (In develop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants