Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

enable incrementals with feature flags #1903

Merged
merged 2 commits into from
Dec 21, 2022
Merged

enable incrementals with feature flags #1903

merged 2 commits into from
Dec 21, 2022

Conversation

ryanfkeepers
Copy link
Contributor

Description

Allows the usage of incrementals via feature-
flag controls. Feature flags can be enabled
on a per-flag basis in either the cli (the flag
is hidden from users, normally) or through the
sdk by directly toggling the flag property
in the control.Options.

Does this PR need a docs update or release note?

  • ⛔ No

Type of change

  • 🌻 Feature

Issue(s)

Test Plan

  • 💪 Manual

@ryanfkeepers
enable incrementals with feature flags
c5f6d16 
Allows the usage of incrementals via feature-
flag controls.  Feature flags can be enabled
on a per-flag basis in either the cli (the flag
is hidden from users, normally) or through the
sdk by directly toggling the flag property
in the control.Options.
@ryanfkeepers ryanfkeepers added enhancement New feature or request cli labels Dec 21, 2022
@ryanfkeepers ryanfkeepers self-assigned this Dec 21, 2022
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:51 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:51 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:51 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:52 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:52 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 19:52 — with GitHub Actions Inactive
ashmrtn
ashmrtn approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@ashmrtn ashmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post manual output of it running both so we know how to use it and so that we have some expectation of what the output is like for incrementals (don't need to post details output as we know that's still pending)

src/internal/operations/backup.go Outdated Show resolved Hide resolved
@ashmrtn ashmrtn mentioned this pull request Dec 21, 2022
Closed
12 tasks
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:17 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:17 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:18 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:18 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:18 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 21, 2022 21:18 — with GitHub Actions Inactive
@ryanfkeepers
Copy link
Contributor Author 

	cd ./corso/src; go run ./corso.go backup create exchange \
	--config-file $dir/.corso_make.toml \
	--no-stats \
	--log-level info \
	--data email \
	--exchange-incrementals \
	--user [email protected]
Connecting to repository:      5s done
Fetching backup heuristics:         done
Connecting to M365:      0s done
Discovering items to backup:     11s done
∙ email - [email protected]:     11s done
Backing up data:      3s done
  Started At            ID                                    Status                Selectors
  2022-12-21T21:21:06Z  95b9e66c-e7a0-48b0-8425-5d99c0ab411a  Completed (0 errors)  [email protected]

@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 21, 2022 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot merged commit 5b6b60d into main Dec 21, 2022
@aviator-app aviator-app bot deleted the issue-1901 branch December 21, 2022 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashmrtn ashmrtn ashmrtn approved these changes

@vkamra vkamra Awaiting requested review from vkamra

Assignees

@ryanfkeepers ryanfkeepers

Labels
cli enhancement New feature or request mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanfkeepers @ashmrtn