Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

add flag to force full backup #1901

Closed
Tracked by #1777
ashmrtn opened this issue Dec 21, 2022 · 2 comments
Closed
Tracked by #1777

add flag to force full backup #1901

ashmrtn opened this issue Dec 21, 2022 · 2 comments
Assignees

Comments

@ashmrtn
Copy link
Contributor

ashmrtn commented Dec 21, 2022

Incremental backups increase the chance that Corso gets into a state where it can't complete a successful backup because new backups depend on the success and correctness of backups before them. Furthermore, the fact that Corso is going to default to trying to make an incremental backup makes it such that the user must delete older backups if they want to force a full backup for any reason.

We should provide a smoother and less destructive experience for making a full backup even when the incrementals code is enabled by providing a (possibly hidden) CLI flag that forces a full backup

aviator-app bot pushed a commit that referenced this issue Dec 21, 2022
## Description

Allows the usage of incrementals via feature-
flag controls.  Feature flags can be enabled
on a per-flag basis in either the cli (the flag
is hidden from users, normally) or through the
sdk by directly toggling the flag property
in the control.Options.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #1901

## Test Plan

- [x] 💪 Manual
@ryanfkeepers ryanfkeepers self-assigned this Dec 22, 2022
@ryanfkeepers
Copy link
Contributor

Started with the inverse: a flag to enable incremental backups for exchange. When we release that behavior and standardize incrementals for exchange, we can use this ticket to remove that feature flag and replace it with a forced full-backup operation.

@ashmrtn
Copy link
Contributor Author

ashmrtn commented Dec 23, 2022

Having a flag to disable a full backup may also require a minor change in how kopia.Wrapper works. Currently BackupCollections takes a single list of bases to make the incremental off of. These bases are used for both building the in-memory hierarchy to hand to kopia and giving to kopia to find cached files (aka kopia-assisted incrementals).

To disable delta token incrementals, we should skip handing the bases to the function that builds the in-memory hierarchy. However we should still take advantage of kopia-assisted incrementals

aviator-app bot pushed a commit that referenced this issue Dec 23, 2022
## Description

Adds a flag to the BackupCollections interface
that identifies whether the caller is running an
incremental backup or not.  If they are, kopia
will utilize the previous base snapshots when
building the directory tree.

## Does this PR need a docs update or release note?

- [x] ⛔ No 

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #1901

## Test Plan

- [x] 💚 E2E
aviator-app bot pushed a commit that referenced this issue Jan 8, 2023
## Description

Sets the default run behavior for exchange to use
incremental backups.  The cli feature flag for enabling exchange incrementals has been swapped for a toggle that disables incrementals, forcing a full backup

## Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #1901

## Test Plan

- [x] ⚡ Unit test
- [x] 💚 E2E
@vkamra vkamra closed this as completed Jan 9, 2023
ryanfkeepers added a commit that referenced this issue Jan 17, 2023
## Description

Sets the default run behavior for exchange to use
incremental backups.  The cli feature flag for enabling exchange incrementals has been swapped for a toggle that disables incrementals, forcing a full backup

## Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included

## Type of change

- [x] 🌻 Feature

## Issue(s)

* #1901

## Test Plan

- [x] ⚡ Unit test
- [x] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants