Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Propagate options to repo and operations #1932

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Propagate options to repo and operations #1932

merged 2 commits into from
Dec 23, 2022

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Dec 23, 2022

Description

Make sure the options struct is passed through the entire stack so we actually have access to flag values.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🐹 Trivial/Minor

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn
Propagate options to repo and operations
6809fd8 
Make sure the options struct is passed through the entire stack so we
actually have access to flag values.
@ashmrtn ashmrtn added the bug Something isn't working label Dec 23, 2022
@ashmrtn ashmrtn requested a review from ryanfkeepers December 23, 2022 16:47
@ashmrtn ashmrtn self-assigned this Dec 23, 2022
@ashmrtn ashmrtn temporarily deployed to Testing December 23, 2022 16:47 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 23, 2022 16:47 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 23, 2022 16:48 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 23, 2022 16:48 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing December 23, 2022 16:48 — with GitHub Actions Inactive
@aviator-app
Copy link
Contributor

aviator-app bot commented Dec 23, 2022 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@ryanfkeepers ryanfkeepers added the blocked Upstream item prevents completion label Dec 23, 2022
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryanfkeepers ryanfkeepers removed the blocked Upstream item prevents completion label Dec 23, 2022
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@ryanfkeepers ryanfkeepers temporarily deployed to Testing December 23, 2022 17:00 — with GitHub Actions Inactive
@aviator-app aviator-app bot merged commit 91b9f2e into main Dec 23, 2022
@aviator-app aviator-app bot deleted the 1931-propagate-opts branch December 23, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@ashmrtn ashmrtn

Labels
bug Something isn't working mergequeue-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

propagate control.Options through the stack
2 participants
@ashmrtn @ryanfkeepers