Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

propagate control.Options through the stack #1931

Closed
ashmrtn opened this issue Dec 23, 2022 · 0 comments · Fixed by #1932
Closed

propagate control.Options through the stack #1931

ashmrtn opened this issue Dec 23, 2022 · 0 comments · Fixed by #1932
Assignees
@ashmrtn
Labels
bug Something isn't working

Comments

@ashmrtn
Copy link
Contributor

ashmrtn commented Dec 23, 2022 •
edited
Loading

bit of a follow-on to #1901, but it seems that control.Options is not propagated from the CLI layer to the operation layer. This makes all options default to their zero-value, meaning incremental backups are still not available at the CLI
@ashmrtn ashmrtn mentioned this issue Dec 23, 2022
Closed
29 tasks
@ashmrtn ashmrtn self-assigned this Dec 23, 2022
@ashmrtn ashmrtn added the bug Something isn't working label Dec 23, 2022
@ashmrtn ashmrtn mentioned this issue Dec 23, 2022
Merged
12 tasks
aviator-app bot pushed a commit that referenced this issue Dec 23, 2022
@ashmrtn
Propagate options to repo and operations (#1932)
91b9f2e 
## Description

Make sure the options struct is passed through the entire stack so we actually have access to flag values.

## Does this PR need a docs update or release note?

- [ ] ✅ Yes, it's included
- [ ] 🕐 Yes, but in a later PR
- [x] ⛔ No 

## Type of change

- [ ] 🌻 Feature
- [x] 🐛 Bugfix
- [ ] 🗺️ Documentation
- [ ] 🤖 Test
- [ ] 💻 CI/Deployment
- [x] 🐹 Trivial/Minor

## Issue(s)

* closes #1931 

## Test Plan

- [x] 💪 Manual
- [ ] ⚡ Unit test
- [ ] 💚 E2E
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashmrtn ashmrtn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate options to repo and operations alcionai/corso
1 participant
@ashmrtn