This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
retain kopia-assist when not on incrementals #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmrtn
reviewed
Dec 23, 2022
| @@ -80,6 +81,7 @@ func (ss *streamStore) WriteBackupDetails( | |||
| ss.service, | |||
| nil, | |||
| nil, | |||
| isIncremental, | |||
There was a problem hiding this comment.
this depends on how much of the underlying incremental behavior we want to expose to higher layer. For now since we're already passing nil for the set of bases I think it's fine to just hardcode it to false and not even expose it as another parameter
There was a problem hiding this comment.
ah, I was looking at the wrong param. You're right, no point in the flag if the input is nil.
ashmrtn
approved these changes
Dec 23, 2022
Adds a flag to the BackupCollections interface that identifies whether the caller is running an incremental backup or not. If they are, kopia will utilize the previous base snapshots when building the directory tree.
ryanfkeepers
force-pushed
the
issue-1901-split-base
branch
from
912a4d4 to
6973b61
Compare
Aviator status
This PR was merged using Aviator. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag to the BackupCollections interface
that identifies whether the caller is running an
incremental backup or not. If they are, kopia
will utilize the previous base snapshots when
building the directory tree.
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan