Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Allow incremental backups for multiple data categories if some metadata is missing #2030

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Allow incremental backups for multiple data categories if some metadata is missing #2030

merged 2 commits into from
Jan 4, 2023

Conversation

ashmrtn
Copy link
Contributor

@ashmrtn ashmrtn commented Jan 4, 2023

Description

Don't return nil if we had an error getting metadata. This gives us the best chance possible of having enough metadata retrieved from the best-effort restore execution flow to actually enable incrementals for some data category.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@ashmrtn
Be less strict about error handling for metadata
b216635 
Don't return nil if we had an error getting metadata. This gives us the
best chance possible of having enough metadata retrieved from the
best-effort restore execution flow to actually enable incrementals for
some data category.
@ashmrtn ashmrtn added the bug Something isn't working label Jan 4, 2023
@ashmrtn ashmrtn requested a review from ryanfkeepers January 4, 2023 18:10
@ashmrtn ashmrtn self-assigned this Jan 4, 2023
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:10 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:10 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:10 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:11 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:11 — with GitHub Actions Inactive
@ashmrtn ashmrtn temporarily deployed to Testing January 4, 2023 18:11 — with GitHub Actions Inactive
@ashmrtn ashmrtn changed the title Allow incremental backups for multiple data categories Allow incremental backups for multiple data categories if some metadata is missing Jan 4, 2023
@aviator-app
Copy link
Contributor

aviator-app bot commented Jan 4, 2023 •
edited
Loading

Aviator status

Aviator will automatically update this comment as the status of the PR changes.

This PR was merged using Aviator.

@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@aviator-app aviator-app bot temporarily deployed to Testing January 4, 2023 18:43 Inactive
@aviator-app aviator-app bot merged commit 84db56c into main Jan 4, 2023
@aviator-app aviator-app bot deleted the incrementals-metadata-retrieve branch January 4, 2023 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanfkeepers ryanfkeepers ryanfkeepers approved these changes

Assignees

@ashmrtn ashmrtn

Labels
bug Something isn't working mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashmrtn @ryanfkeepers