Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Allow incremental backups for multiple data categories if some metadata is missing #2030

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Allow incremental backups for multiple data categories if some metadata is missing #2030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b216635
Be less strict about error handling for metadata
ashmrtn Jan 4, 2023
d9d30ad
Merge branch 'main' into incrementals-metadata-retrieve
aviator-app[bot] Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/internal/operations/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,10 @@ func collectMetadata(

dcs, err := r.RestoreMultipleItems(ctx, string(man.ID), paths, nil)
if err != nil {
return nil, errors.Wrap(err, "collecting prior metadata")
// Restore is best-effort and we want to keep it that way since we want to
// return as much metadata as we can to reduce the work we'll need to do.
// Just wrap the error here for better reporting/debugging.
return dcs, errors.Wrap(err, "collecting prior metadata")
}

return dcs, nil
Expand Down