-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does nothing if inputSelector finds 2 or more tags #74
Comments
What would be the best behavior for you? Code-wise, the easiest would be to enable docsearch only on the first one. The library does not react really well to multiple inputs. |
We should throw so that we are explicit and the user can see he made a mistake. |
If it's already failing then it's the easiest to throw explicit error? |
I would throw an error, but enable on the first one |
Ok, I'll have a look at that |
I would really throw and explain to the user he made something bad. Fixing bugs for him will bite you :D |
@vvo @ElPicador I've submitted the PR here: #80 It will now throw an error if there is not exactly one input matching |
For the record, that was a bug of autocomplete.js's standalone version (Zepto based): it has been fixed - not yet release - and you can now setup your dropdown menu on several search bars. |
So we can close this issue? |
Once we've upgraded to |
If there is in the page 2 or more selectors that matches
inputSelector
it does nothing.The text was updated successfully, but these errors were encountered: