Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): Throw errors if not exactly one input matching #80

Closed
wants to merge 1 commit into from

Conversation

pixelastic
Copy link
Contributor

Fixes #74

@algobot
Copy link

algobot commented Mar 10, 2016

By analyzing the blame information on this pull request, we identified @bobylito, @redox and @vvo to be potential reviewers

@redox
Copy link
Contributor

redox commented Mar 16, 2016

I think we should rather rely on the latest (not deployed yet) version of autocomplete.js to handle multiple search bars. Not throwing anything to keep it jquery-style: $('.whatever').show().hide().doesntthrow()

@pixelastic
Copy link
Contributor Author

@redox: Is the new version you're talking about now deployed?

I did not get the $('.whatever').show().hide().doesntthrow() part

@redox
Copy link
Contributor

redox commented Mar 21, 2016

About to release it.

redox added a commit that referenced this pull request Mar 21, 2016
This includes latest autocomplete.js to handle multiple inputs binding.

Ref #74 & #80
@redox redox mentioned this pull request Mar 21, 2016
@redox
Copy link
Contributor

redox commented Mar 21, 2016

By upgrading to autocomplete.js=0.17.2 we're now able to bind the dropdown menu to several inputs, like it was already for jquery. Closing this PR.

@redox redox closed this Mar 21, 2016
@redox redox deleted the fix/74-multiple-inputs branch March 21, 2016 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants