Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the service load independent of adblocker #880

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: make the service load independent of adblocker #880

merged 1 commit into from
Jun 26, 2024

Conversation

dylantientcheu
Copy link
Contributor

The query to https://raw.githubusercontent.com/badmojr/1Hosts/master/Pro/domains.txt often make the service startup fail.

We restart this service each time it fails, creating multiple request.

This PR separates the browser startup task from the adblocker load. It lets the adblocker fail "silently", and will definitely still run the browser

@dylantientcheu dylantientcheu self-assigned this Jun 26, 2024
8bittitan
8bittitan approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@8bittitan 8bittitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dylantientcheu dylantientcheu merged commit 8d6512b into master Jun 26, 2024
2 checks passed
@dylantientcheu dylantientcheu deleted the fix/adblocker-err-catch branch June 26, 2024 19:30
@dylantientcheu dylantientcheu mentioned this pull request Jun 27, 2024
Merged
algolia-bot added a commit that referenced this pull request Jun 27, 2024
@algolia-bot
chore(release): 2.2.15 [skip ci]
8f41892 
## [2.2.15](v2.2.14...v2.2.15) (2024-06-27)

### Bug Fixes

* dependencies 2023-11-13 ([#870](#870)) ([93fad22](93fad22)), closes [#871](#871)
* make the service load independent of adblocker ([#880](#880)) ([8d6512b](8d6512b))
* use old lockfile ([#881](#881)) ([4ae8d80](4ae8d80))
@dylantientcheu dylantientcheu mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbellone sbellone sbellone left review comments

@8bittitan 8bittitan 8bittitan approved these changes

@clemfromspace clemfromspace Awaiting requested review from clemfromspace

@levimichael levimichael Awaiting requested review from levimichael

@loicsay loicsay Awaiting requested review from loicsay

Assignees

@dylantientcheu dylantientcheu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylantientcheu @sbellone @8bittitan