Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save adblock hosts at compile time #882

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

dylantientcheu
Copy link
Contributor

@dylantientcheu dylantientcheu commented Jun 28, 2024

What

Saving adblocks host list file at compile time.

DEX-1437

Why

We previously fetched the raw file from Github at each Renderscript start, now we fetch it at build, keep the file and read it from fs (filesystem).

Related to:
#880

sbellone
sbellone previously approved these changes Jun 28, 2024
Copy link
Collaborator

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

package.json Outdated Show resolved Hide resolved
clemfromspace
clemfromspace previously approved these changes Jun 28, 2024
Copy link

@clemfromspace clemfromspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dylantientcheu dylantientcheu dismissed stale reviews from clemfromspace and sbellone via bfb0ad5 June 28, 2024 10:05
sbellone
sbellone previously approved these changes Jun 28, 2024
scripts/update_adblock_hosts.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@dylantientcheu dylantientcheu merged commit 7ec6f28 into master Jun 28, 2024
2 checks passed
@dylantientcheu dylantientcheu deleted the fix/adblock-hosts branch June 28, 2024 13:04
algolia-bot added a commit that referenced this pull request Jun 30, 2024
## [2.2.16](v2.2.15...v2.2.16) (2024-06-30)

### Bug Fixes

* save adblock hosts at compile time ([#882](#882)) ([7ec6f28](7ec6f28))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants