-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v1.3.0 #170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs(readme): update documentation * docs(migration): add migration file * chore(package): update description
* chore: configure rollup to generate two builds * chore: remove unused option (browser) from rollup config * chore: add process.maybeNode * chore: add __BROWSER_BUILD__ instead of process.maybeNode * chore: make two entries * chore: export aa function in node build * chore: instantiate AlgoliaInsights every time in tests * chore: rename entry files * chore: use top-level beforeEach * chore: rename getAa to getFuctionalInterface * fix(compat): node compatibility [PART-2] (#141) * fix(compat): disable anonymous tracking on env without cookies * chore: move supportsCookies to featureDetection * chore: process queue only on browser * chore: throw when user token is not set * chore: add jest watch typeahead plugin (#143) * chore: add jest watch typeahead plugin * chore: pin dependency * chore: add __BROWSER_BUILD__ instead of process.maybeNode * chore: add __BROWSER_BUILD__ condition * chore: fix broken test * chore: remove __BROWSER_BUILD__ * chore: process queue only on browser build * fix: process queue inside browser module * chore: fix test cases * chore: update travis config regarding xvfb (#144) * chore: rename getAa to getFuctionalInterface * chore: remove the duplicates * fix: remove useless argument * chore: move getInsatnceXX functions to _instance * fix(compat): node compatibility [PART-3] (#142) * chore: add util functions and tests * chore: add request function which wraps sendBeacon, xhr and node http * chore: apply feedback Co-Authored-By: Youcef Mammar <[email protected]> * chore: apply feedbacks Co-Authored-By: Youcef Mammar <[email protected]> * chore: require http/https dynamically to clean browser build * chore: remove node http related code from browser build * chore: remove __BROWSER_BUILD__ * chore: fix tests for sendEvent in node * fix: pass requestFn to AlgoliaAnalytics * chore: remove _instance and use AlgoliaAnalytics instead * chore: split getRequester * fix: change parameters of request for node 8.x node 8.x and 10.x have different signautures for 'request' function. - node 8.x: https://nodejs.org/docs/latest-v8.x/api/https.html#https_https_request_options_callback - node 10.x: https://nodejs.org/dist/latest-v10.x/docs/api/https.html#https_https_request_options_callback * fix: allow userToken in event payload * fix: remove the duplicated assignment * fix: check userToken for only undefined * chore: rename AlgoliaInsights with analyticsInstance in test cases * fix: add `new` at `TypeError`s Co-Authored-By: Haroen Viaene <[email protected]> * chore: apply suggestions from code review Co-Authored-By: Haroen Viaene <[email protected]> * fix: update inline snapshot of test case * fix: add `new` at `TypeError`s * chore: inline AlgoliaAnalyticsOptions type * chore: use `isUndefined` helper * fix: throw when userToken is an empty string * fix: improve test case * fix: split a test case * chore: update feedback from review Co-Authored-By: Youcef Mammar <[email protected]>
* docs: add a section for node module * docs: add TOC * docs: apply feedbacks Co-Authored-By: Youcef Mammar <[email protected]> * docs: move Node.js part under getting started * docs: update setUserToken part * docs: apply changes again * docs: apply suggestions from code review Co-Authored-By: François Chalifour <[email protected]> * docs: apply feedbacks * docs: update TOC
* chore: add changelog * docs: remove verbose changelogs * chore: pin the version of conventional-changelog
* chore(gtm): add Google Tag Manager custom template * docs(readme): change GTM mentions location Co-Authored-By: Haroen Viaene <[email protected]> * docs(readme): add FAQ section for `positions` * docs(readme):remove word `starting` * fix(gtm): rename endpoint to source URL * fix(gtm): convert positions to integers * fix(gtm): don't pass `positions` in `clickedObjectIDs` * docs(readme): document how to create variables * fix: rename template to Search Insights * fix(gtm): rename initialUserToken * fix(gtm): rename `eventType` to `method` * feat(gtm): convert `region` to select * fix(gtm): improve interface * fix(gtm): rename template with Algolia prefix * fix(gtm): add regex validator for `userToken` * fix(gtm):allow more permissive `eventName`s Format: any ASCII char except control characters. Length: between 1 and 64 characters. https://www.algolia.com/doc/api-reference/api-methods/clicked-object-ids-after-search/#method-param-eventname * fix(gtm): log before sending events
francoischalifour
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions unrelated to this PR itself.
4a9ae11
to
d232bbc
Compare
Co-Authored-By: François Chalifour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not many things are added since
v1.3.0-beta.0
.It includes GTM, but it's added as a
chore
commit and it's actually not a feature added tosearch-insights
. So I haven't added it to the CHANGELOG.Last time the PR for
v1.3.0-beta.0
(#165) was created but I squashed and merged it tomaster
.So at that time only one squashed commit was added to
master
.I should've just merged it so that all the commits from
develop
are added tomaster
as is.So basically the commits you see below are difference between
v1.2.0
andv1.3.0
.This time, I will not squash and just merge it to
master
. Then it'd be easier to comparedevelop
andmaster
.