Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Add Slack notifications for rel/nightly failures #2643

Merged
merged 31 commits into from
Aug 11, 2021
Merged

CircleCI: Add Slack notifications for rel/nightly failures #2643

merged 31 commits into from
Aug 11, 2021

Conversation

algobarb
Copy link
Contributor

@algobarb algobarb commented Jul 27, 2021

Summary

Add slack notifications for rel/nightly failures.

This will help us easily track Circle CI rel/nightly test failures on our slack channel.

Details

I leveraged the following article: https://circleci.com/blog/circleci-slack-integration/
and this wiki: https://github.com/CircleCI-Public/slack-orb/wiki/Setup

We currently disable "Pass secrets to builds from forked pull requests" in our Circle CI configurations to protect our environment variables., so I'm unable to test this change until it runs on the official go-algorand repo. The notification changes are only applied to "nightly" tests failures on the "rel/nightly" branch.

Future

After implementing notifications on the "rel/nightly" branch in this PR, we can consider changing the filter to all release branches.

@algobarb algobarb changed the title [CircleCI - Do not merge] CircleCI: Add Slack notifications for rel/nightly failures Aug 9, 2021
@algobarb algobarb self-assigned this Aug 9, 2021
@algobarb algobarb marked this pull request as ready for review August 10, 2021 14:10
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my quick grok it looks fine, but I guess we need to merge it to see

@algojohnlee algojohnlee merged commit 4a8c41b into algorand:master Aug 11, 2021
@algobarb algobarb deleted the barbara/circleslack branch August 11, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants