Run all tests on hotfix branches too #2692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algobarb
reviewed
Aug 5, 2021
Co-authored-by: algobarb <[email protected]>
…orand/go-algorand into brice/runAllTestsHotfixes
|
@bricerisingalgorand Sorry, my bad it doesn't need the "" around regexes, should just be |
algobarb
approved these changes
Aug 6, 2021
|
I wonder if we still need this or whether if we want to consider changing it to run nightly over all "rel/*" branches after the slack ticket #2643 gets merged in and tested on "rel/nightly". |
onetechnical
approved these changes
Aug 11, 2021
|
pulled in hotfix change into #2729 . Closing this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to run all tests on hotfix branches in addition to rel/nightly, since hotfix changes will not go through the standard rel/nightly merge.
Test Plan
I plan to test this by creating a hotfix branch and seeing that it runs all tests