Bug-Fix: ABI encode infer to slice IsNil handler removal #3823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the input of array in golang to function
inferToSlice
, the previous implementation will try to inferIsNil
from interface value, while this will cause panic.Solution here is to remove following code snippet
since on passing nil slice, we still want to return an empty (len == 0) slice of interface, rather than a nil slice, which will cause trouble in implementation.
This is a fix for algorand/go-algorand-sdk#302