Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-Fix: ABI inferToSlice nil testcases #3826

Merged
merged 6 commits into from
Mar 24, 2022
Merged

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Mar 23, 2022

Description

A follow-up PR from #3823, adding one moar testcase to test inferToSlice will error when passing a nil with unexpected type (i.e., type other than slice or array).

tzaffi
tzaffi previously approved these changes Mar 23, 2022
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasonpaulos
jasonpaulos previously approved these changes Mar 23, 2022
Copy link
Contributor

@jasonpaulos jasonpaulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

michaeldiamant
michaeldiamant previously approved these changes Mar 23, 2022
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahangsu Thanks for bringing in my feedback around additional test cases. ☕

jasonpaulos
jasonpaulos previously approved these changes Mar 23, 2022
jannotti
jannotti previously approved these changes Mar 23, 2022
@ahangsu ahangsu changed the title ABI inferToSlice nil testcases Bug-Fix:ABI inferToSlice nil testcases Mar 23, 2022
@ahangsu ahangsu changed the title Bug-Fix:ABI inferToSlice nil testcases Bug-Fix: ABI inferToSlice nil testcases Mar 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #3826 (b312bb1) into master (32cfc42) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3826   +/-   ##
=======================================
  Coverage   49.99%   49.99%           
=======================================
  Files         392      392           
  Lines       68495    68491    -4     
=======================================
- Hits        34242    34240    -2     
+ Misses      30497    30496    -1     
+ Partials     3756     3755    -1     
Impacted Files Coverage Δ
data/abi/abi_encode.go 62.50% <ø> (+1.23%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
data/abi/abi_type.go 87.67% <0.00%> (-0.95%) ⬇️
data/transactions/verify/txn.go 44.15% <0.00%> (-0.87%) ⬇️
catchup/service.go 68.88% <0.00%> (-0.75%) ⬇️
ledger/acctupdates.go 68.51% <0.00%> (-0.66%) ⬇️
util/metrics/counter.go 80.95% <0.00%> (+2.38%) ⬆️
util/metrics/gauge.go 70.66% <0.00%> (+2.66%) ⬆️
ledger/tracker.go 74.67% <0.00%> (+3.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c0fee...b312bb1. Read the comment docs.

@ahangsu ahangsu dismissed stale reviews from jannotti and jasonpaulos via b312bb1 March 24, 2022 14:07
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahangsu Thanks for the effort to add test cases here. ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants