-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug-Fix: ABI inferToSlice nil testcases #3826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahangsu Thanks for bringing in my feedback around additional test cases. ☕
6718b51
Codecov Report
@@ Coverage Diff @@
## master #3826 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 392 392
Lines 68495 68491 -4
=======================================
- Hits 34242 34240 -2
+ Misses 30497 30496 -1
+ Partials 3756 3755 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahangsu Thanks for the effort to add test cases here. ☕
Description
A follow-up PR from #3823, adding one moar testcase to test
inferToSlice
will error when passing anil
with unexpected type (i.e., type other than slice or array).