Developer Tools: create indexer data dir #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #991 +/- ##
========================================
Coverage 60.17% 60.17%
========================================
Files 41 41
Lines 5700 5700
========================================
Hits 3430 3430
Misses 1824 1824
Partials 446 446 Continue to review full report at Codecov.
|
winder
reviewed
May 9, 2022
cmd/algorand-indexer/daemon.go
Outdated
| @@ -185,6 +197,8 @@ func init() { | |||
| daemonCmd.Flags().Uint32VarP(&maxApplicationsLimit, "max-applications-limit", "", 1000, "set the maximum allowed Limit parameter for querying applications") | |||
| daemonCmd.Flags().Uint32VarP(&defaultApplicationsLimit, "default-applications-limit", "", 100, "set the default Limit parameter for querying applications, if none is provided") | |||
|
|
|||
| daemonCmd.Flags().StringVarP(&indexerDataDir, "datadir", "i", "", "path to indexer data dir, or $INDEXER_DATA") | |||
There was a problem hiding this comment.
nit: kebab case used for other parameters
Suggested change
| daemonCmd.Flags().StringVarP(&indexerDataDir, "datadir", "i", "", "path to indexer data dir, or $INDEXER_DATA") | |
| daemonCmd.Flags().StringVarP(&indexerDataDir, "data-dir", "i", "", "path to indexer data dir, or $INDEXER_DATA") |
winder
reviewed
May 9, 2022
winder
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create a data directory for indexer
Test Plan
run cmd manually to validate directory is created only if it doesn't exist already.