Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOR REVIEW ONLY: indexer 2.12.0 into master #1033

Merged
merged 15 commits into from
Jun 22, 2022
Merged

FOR REVIEW ONLY: indexer 2.12.0 into master #1033

merged 15 commits into from
Jun 22, 2022

Conversation

Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Jun 15, 2022 •
edited by algobarb
Loading

GitHub Logo

Overview

Support for Mac with ARM arcitecture, new data directory for future caching optimizations, upgrade golang compiler to 1.17.

Highlights

Indexer Data Directory

In an effort to consolidate configuration, and create a location for more sophisticated caching, there is a new data directory parameter. The data directory is required and can be specified with one of the following:

  • Command line flag -i or --data-dir
  • YAML file field: data
  • Environment variable: INDEXER_DATA

What's New

  • Data directory support, --data-dir flag is now a required argument
  • golang upgraded to 1.17

Changelog

New Features

  • Developer Tools: create indexer data dir (#991)
  • New Feature: Adds Data Directory Support (#1012)

Enhancements

Bugfixes

  • API: return empty lists from fetchApplications and fetchAppLocalStates (#1010)
  • API Model: Update model to converge with algod (#1005)
  • Ci: add version to golint install command. (#1000)

Not Yet Enabled

  • Developer Tools: indexer block processor (#982)

New Contributors

Additional Resources

Algo-devops-service and others added 12 commits May 4, 2022 17:08
@Algo-devops-service
Merge branch 'release/2.11.1' into develop
457adcf
@shiqizng
Developer Tools: create indexer data dir (#991)
58e68aa
@shiqizng
Developer Tools: indexer block processor (#982)
ce34b6f
@Eric-Warehime
build: Update for Mac M1 support (#980)
491c684
@winder
Add tests for account asset amount validation. (#994)
9b6cb78
@Eric-Warehime
CI: switch to codecov github action (#995)
7dbf4b4
@winder
ci: add version to golint install command. (#1000)
f26fca1
@erer1243
return empty lists from fetchApplications and fetchAppLocalStates (#1010
9f1dea3 
)
@Eric-Warehime
Update model to converge with algod (#1005)
7c19c7d
@AlgoStephenAkiki
New Feature: Adds Data Directory Support (#1012)
c9f5dc0 
- Updates the go-algorand submodule hash to point to rel/beta
- Moves the cpu profiling file, pid file and indexer configuration file
  to be options of only the daemon sub-command
- Changes os.Exit() to be a panic with a special handler.  This is so
  that defer's are handled instead of being ignored.
- Detects auto-loading configuration files in the data directory and
  issues errors if equivalent command line arguments are supplied.
- Updates the README with instructions on how to use the auto-loading
  configuration files and the data directory.
@Algo-devops-service
Bump version to 2.12.0-rc1
90426fc
@Eric-Warehime
Lock to mockery minor version (#1038)
475f416
@algobarb algobarb added the Enhancement New feature or request label Jun 16, 2022
@algobarb algobarb changed the title FOR REVIEW ONLY: indexer 2.12.0 into master FOR-REVIEW-ONLY: indexer 2.12.0 into master Jun 16, 2022
@algobarb algobarb added New Feature Enhancement New feature or request and removed Enhancement New feature or request New Feature labels Jun 16, 2022
@algobarb algobarb changed the title FOR-REVIEW-ONLY: indexer 2.12.0 into master FOR REVIEW ONLY: indexer 2.12.0 into master Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1033 (5ef6459) into master (b4d34f1) will decrease coverage by 0.62%.
The diff coverage is 83.09%.

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   60.17%   59.54%   -0.63%     
==========================================
  Files          41       45       +4     
  Lines        5700     8353    +2653     
==========================================
+ Hits         3430     4974    +1544     
- Misses       1824     2920    +1096     
- Partials      446      459      +13
Impacted Files Coverage Δ
api/generated/common/routes.go 46.51% <ø> (+13.17%) ⬆️
api/generated/v2/routes.go 17.76% <ø> (-1.17%) ⬇️
config/config.go 0.00% <ø> (ø)
util/util.go 70.00% <78.57%> (-1.43%) ⬇️
processor/blockprocessor/block_processor.go 83.33% <83.33%> (ø)
api/handlers.go 72.68% <100.00%> (-1.63%) ⬇️
accounting/eval_preload.go 77.24% <0.00%> (-3.89%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d34f1...5ef6459. Read the comment docs.

@algobarb algobarb self-assigned this Jun 22, 2022
@algobarb algobarb marked this pull request as ready for review June 22, 2022 14:27
@Algo-devops-service Algo-devops-service merged commit d4a7e91 into master Jun 22, 2022
@algobarb algobarb deleted the release/2.12.0 branch June 22, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlgoStephenAkiki AlgoStephenAkiki AlgoStephenAkiki approved these changes

@algojack algojack algojack approved these changes

@winder winder Awaiting requested review from winder

@shiqizng shiqizng Awaiting requested review from shiqizng

@algobarb algobarb Awaiting requested review from algobarb algobarb was automatically assigned from algorand/devops

@algolucky algolucky Awaiting requested review from algolucky algolucky was automatically assigned from algorand/devops

Assignees

@algobarb algobarb

Labels
Enhancement New feature or request Team Hyper Flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Algo-devops-service @AlgoStephenAkiki @algojack @algobarb @shiqizng @Eric-Warehime @winder @erer1243