CI: switch to codecov CircleCI orb

[Eric-Warehime]

Summary

Add a codecov config file to directly configure upload steps instead of using the bash uploader since that has been deprecated.

[codecov-commenter]

Codecov Report

Merging #995 (7c5243c) into develop (491c684) will decrease coverage by 1.28%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #995      +/-   ##
===========================================
- Coverage    60.43%   59.15%   -1.29%     
===========================================
  Files           42       45       +3     
  Lines         5750     8353    +2603     
===========================================
+ Hits          3475     4941    +1466     
- Misses        1827     2950    +1123     
- Partials       448      462      +14     

Impacted Files	Coverage Δ
util/util.go	70.00% <0.00%> (-10.77%)	⬇️
accounting/eval_preload.go	77.24% <0.00%> (-3.89%)	⬇️
api/handlers.go	72.68% <0.00%> (-1.63%)	⬇️
api/generated/v2/routes.go	17.76% <0.00%> (-1.17%)	⬇️
fetcher/fetcher.go	33.77% <0.00%> (-0.96%)	⬇️
api/converter_utils.go	91.23% <0.00%> (-0.96%)	⬇️
idb/postgres/internal/util/util.go	73.52% <0.00%> (-0.94%)	⬇️
processor/blockprocessor/block_processor.go	83.33% <0.00%> (-0.88%)	⬇️
idb/postgres/internal/writer/write_txn.go	82.67% <0.00%> (-0.83%)	⬇️
...gres/internal/migrations/convert_account_data/m.go	62.58% <0.00%> (-0.57%)	⬇️
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491c684...7c5243c. Read the comment docs.

[algojack]

I know you are still working on this, but once you are ready if you can please replace upload_coverage on line 64 in .circleci/config.yml too, and delete the upload_coverage.sh script

[Eric-Warehime]

I looked into why the coverage is changing in this PR (causing it to fail as intended when coverage decreases) even though we're not actually touching the code being tested.

I suspect the answer is hidden in this bash script though I haven't identified the exact cause. It is re-writing the coverage file before uploading (you can see the # path=fixes section in a coverage file produced by the bash script like this one which does not exist in the uploaded file from the new codecov uploader. This leads me to believe there is some altering of data happening affecting which files we're tracking.

Regardless of the root cause of the above, the difference we're seeing is that the previously untracked files config/config.go, util/metrics/metrics.go, and util/diff.go are now being reported in new coverage reports which is causing the coverage to drop. I think we can either ignore that failure and merge this or I can update the codecov config to not fail on coverage drops in this PR and submit a followup PR to enable the failure which should show a 0% drop and pass.

[winder]

What do you think about setting a coverage target for new code only? We can discuss the target, I'd consider something like 75% to start but maybe we can go higher?

https://docs.codecov.com/docs/common-recipe-list#ensure-all-code-is-covered

[Eric-Warehime]

The default config has a project check which checks the coverage of the project as a whole is non-decreasing, and a patch check which verifies the coverage in the PR is greater than some limit you set.

I disabled the patch in favor of just ensuring that we're always increasing coverage as a whole. My thinking was that setting 70% per patch will never guarantee that we get above 70% while just ensuring that we're improving the project's coverage in theory will.

I'm open to different settings if people have strong opinions about it.

[Eric-Warehime]

Discussed this morning and we've agreed to track the coverage % in the patch, and to initially prevent it from blocking PRs on failure. In the future as we get more complete coverage we will enable it to block PRs on failure.

[cce]

updated title, this uses a circleci orb, not a github action