Merge pull request #782 from bindoon/fix-set-undefined-value

Fix(NumberPicker): set null to reset value
alibaba-fusion · Jun 13, 2019 · 41ae904 · 41ae904
2 parents ba8083c + e4220c6
commit 41ae904
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/number-picker/index.jsx b/src/number-picker/index.jsx
@@ -144,8 +144,9 @@ class NumberPicker extends React.Component {
 
     componentWillReceiveProps(nextProps) {
         if ('value' in nextProps) {
+            const value = nextProps.value;
             this.setState({
-                value: nextProps.value === undefined ? '' : nextProps.value,
+                value: value === undefined || value === null ? '' : value,
             });
         }
     }

diff --git a/test/number-picker/index-spec.js b/test/number-picker/index-spec.js
@@ -569,6 +569,9 @@ describe('number-picker', () => {
             wrapper.setProps({ value: undefined });
             assert(wrapper.find('input').prop('value') === '');
 
+            wrapper.setProps({ value: null });
+            assert(wrapper.find('input').prop('value') === '');
+
             done();
         });
     });