Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(NumberPicker): set null to reset value #782

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

bindoon
Copy link
Member

@bindoon bindoon commented Jun 13, 2019

support null to reset NumberPicker

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #782 into master will increase coverage by 6.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   84.72%   91.31%   +6.59%     
==========================================
  Files         244      244              
  Lines       11245    14013    +2768     
  Branches     2806     4399    +1593     
==========================================
+ Hits         9527    12796    +3269     
- Misses        913     1198     +285     
+ Partials      805       19     -786
Impacted Files Coverage Δ
src/number-picker/index.jsx 96.72% <100%> (+8.25%) ⬆️
src/menu/view/radio-item.jsx 66.66% <0%> (-33.34%) ⬇️
src/menu/view/checkbox-item.jsx 75% <0%> (-25%) ⬇️
src/util/dom.js 87.87% <0%> (-12.13%) ⬇️
src/tab/tabs/utils.js 86.95% <0%> (-6.38%) ⬇️
src/table/fixed/body.jsx 66.66% <0%> (-6.07%) ⬇️
src/table/base/resize.jsx 90% <0%> (-5.24%) ⬇️
src/calendar/head/card-header.jsx 80.64% <0%> (-2.69%) ⬇️
src/slider/slick/mixins/trackHelper.js 86.36% <0%> (-2.68%) ⬇️
src/upload/runtime/html5-uploader.jsx 88.23% <0%> (-2.68%) ⬇️
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8083c...e4220c6. Read the comment docs.

@bindoon bindoon force-pushed the fix-set-undefined-value branch from dfef805 to e4220c6 Compare June 13, 2019 03:13
@bindoon bindoon changed the title Fix set undefined value Fix(NumberPicker): set null to reset value Jun 13, 2019
@youluna youluna merged commit 41ae904 into alibaba-fusion:master Jun 13, 2019
@bindoon bindoon deleted the fix-set-undefined-value branch August 12, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants