Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dp algo to xgb #443

Closed
wants to merge 36 commits into from
Closed

Add dp algo to xgb #443

wants to merge 36 commits into from

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Nov 28, 2022

As the title says.

qbc2016 added 28 commits October 17, 2022 20:29
@qbc2016
20221017
b677cc0
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope
eb8f7db
@qbc2016
refine master
f1e3b99
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope
89f103e
@qbc2016
fix yaml, need fix givemesomecredit
60cda5b
@qbc2016
temperory files, need further repairation, may work for 'adult', no f…
0ef0135 
…or 'credit'
@qbc2016
dataset 'adult' for vertical fl
228fa72
@qbc2016
delete redundant
78c0d4b
@qbc2016
fix typo
5db4bbf
@qbc2016
minor changes
1667e6d
@qbc2016
modified according to the comments
60949b9
@qbc2016
add a parameter 'model' to dataset to decide whether to change the la…
d44121d 
…bel form 0 to -1 or not
@qbc2016
minor changes
96614a3
@qbc2016
Merge branch 'dev_vertical_data'
f1af88d
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope
21ffc9e
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope
8e2ae16
@qbc2016
add 3 more datasets for xgb_base
34bde98
@qbc2016
rm 'test_acc' for Regression
1f7b87a
@qbc2016
add round 0 logger info
0c89190
@qbc2016
refine test proceduce (with much annotation)
131acef
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope in…
e058f38 
…to HEAD
@qbc2016
refine 3 other datasets .py files for partitioning test data
9f2d751
@qbc2016
add feedback during training with much annatation
29f1404
@qbc2016
add dp noises function
6caa28f
@qbc2016
ad DP selection in yaml file
22ec534
@qbc2016
minor changes
d98c896
@qbc2016
Merge branch 'master' of https://github.com/alibaba/FederatedScope in…
12eeaab 
…to dev_xgb_dp
@qbc2016
minor changes
75bb49b
@xieyxclack xieyxclack self-requested a review December 5, 2022 08:38
@xieyxclack xieyxclack added the Tree label Dec 5, 2022
xieyxclack
xieyxclack previously approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@xieyxclack xieyxclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please double-check the configured values in the provided yaml files, and we might need to re-organize the configuration for fl-xgb later.

@xieyxclack xieyxclack added the Feature New feature label Dec 5, 2022
@xieyxclack xieyxclack mentioned this pull request Jan 18, 2023
Merged
@xieyxclack
Copy link
Collaborator

This pr is closed since it has been included in #497 , thanks a lot for the contributions of @qbc2016

@xieyxclack xieyxclack closed this Jan 31, 2023
@qbc2016 qbc2016 deleted the dev_xgb_dp branch June 8, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xieyxclack xieyxclack xieyxclack left review comments

Assignees
No one assigned
Labels
Feature New feature Tree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbc2016 @xieyxclack