Add protect method for feature order in fl-xgb #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbc2016
reviewed
Jan 18, 2023
| min_value = min(data[feature_order_frame][:, i]) | ||
| max_value = max(data[feature_order_frame][:, i]) | ||
| if j == 0: | ||
| self.split_value[i][idx_end] = max_value |
There was a problem hiding this comment.
The value on the right hand side should be divided by 2.0
qbc2016
reviewed
Jan 18, 2023
qbc2016
reviewed
Jan 18, 2023
federatedscope/vertical_fl/trainer/feature_order_protected_trainer.py
Outdated
Show resolved
Hide resolved
qbc2016
reviewed
Jan 19, 2023
| 'extra_info': extra_info | ||
| } | ||
|
|
||
| def _get_feature_order_info(self, data): |
There was a problem hiding this comment.
For convenience, I also protected the label owner's feature order before. Actually, label owner does not need to do this.
There was a problem hiding this comment.
Since it need some more efforts to fix this issue such as modifying the split position accordingly, we can add TODO item here and fix it later
qbc2016
reviewed
Jan 29, 2023
qbc2016
reviewed
Jan 29, 2023
federatedscope/vertical_fl/xgb_base/baseline/xgb_base_on_blogfeedback.yaml
Show resolved
Hide resolved
xieyxclack
changed the title
This was referenced Jan 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for the co-contributor @qbc2016, and sorry the mess commits due to the squash merge of #482