Add SWA #519
Merged
Add SWA #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joneswong
reviewed
Feb 10, 2023
| @@ -25,6 +25,14 @@ def extend_fl_algo_cfg(cfg): | |||
| cfg.fedprox.use = False | |||
| cfg.fedprox.mu = 0. | |||
|
|
|||
| # ---------------------------------------------------------------------- # | |||
There was a problem hiding this comment.
I am wondering whether it is appropriate to put SWA here. It is not an FL algorithm but just a trick to produce another solution from those in the late stage of a training course.
joneswong
reviewed
Feb 10, 2023
| @@ -166,6 +166,9 @@ def _setup_server(self, resource_info=None, client_resource_info=None): | |||
| if self.cfg.vertical.use: | |||
| from federatedscope.vertical_fl.utils import wrap_vertical_server | |||
| server = wrap_vertical_server(server, self.cfg) | |||
| if self.cfg.fedswa.use: | |||
There was a problem hiding this comment.
This implementation implies that, in the future, we'd better refactor the workers so that we would not need to make another worker class just for adding such a trick.
joneswong
reviewed
Feb 10, 2023
joneswong
reviewed
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is linked to #517 .
Besides SWA, I support
merge_valin global evaluation.