Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] FeaturesViewer: track endpoints #1838

Merged
merged 2 commits into from
Feb 14, 2023
Merged

[ui] FeaturesViewer: track endpoints #1838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ece2371
[ui] display track endpoints option in features viewer
mugulmd Dec 5, 2022
e9a75c8
[ui] FeaturesViewer: make time window spinbox editable
mugulmd Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions meshroom/ui/qml/Viewer/FeaturesInfoOverlay.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,20 @@ FloatingPane {
onClicked: root.featuresViewer.display3dTracks = display3dTracksCB.checked
}
}
RowLayout {
Label {
text: "Display Track Endpoints:"
}
CheckBox {
id: displayTrackEndpointsCB
ToolTip.text: "Draws markers indicating the global start/end point of each track."
ToolTip.visible: hovered
Layout.fillHeight: true
Layout.alignment: Qt.AlignRight
checked: root.featuresViewer.displayTrackEndpoints
onClicked: root.featuresViewer.displayTrackEndpoints = displayTrackEndpointsCB.checked
}
}
RowLayout {
Label {
text: "Time Window:"
Expand All @@ -145,17 +159,18 @@ FloatingPane {
to: 50
value: root.mfeatures.timeWindow
stepSize: 1
editable: true

textFromValue: function(value) {
textFromValue: function(value, locale) {
if (value == -1) return "No Limit";
if (value == 0) return "Disable";
return value;
}

valueFromText: function(text) {
if (value == "No Limit") return -1;
if (value == "Disable") return 0;
return value;
valueFromText: function(text, locale) {
if (text == "No Limit") return -1;
if (text == "Disable") return 0;
return Number.fromLocaleString(locale, text);
}

onValueChanged: {
Expand Down
3 changes: 3 additions & 0 deletions meshroom/ui/qml/Viewer/FeaturesViewer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Repeater {
property bool trackContiguousFilter: true
/// Display only tracks with at least one inlier
property bool trackInliersFilter: false
/// Display track endpoints
property bool displayTrackEndpoints: true
/// The list of colors used for displaying several describers
property var colors: [Colors.blue, Colors.green, Colors.yellow, Colors.cyan, Colors.pink, Colors.lime] //, Colors.orange, Colors.red

Expand All @@ -49,6 +51,7 @@ Repeater {
display3dTracks: root.display3dTracks
trackContiguousFilter: root.trackContiguousFilter
trackInliersFilter: root.trackInliersFilter
displayTrackEndpoints: root.displayTrackEndpoints
featureColor: root.colors[colorIndex]
matchColor: Colors.orange
landmarkColor: Colors.red
Expand Down