[ui] FeaturesViewer: track endpoints #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-dl
reviewed
Jan 24, 2023
There was a problem hiding this comment.
This PR does not seem to introduce bugs or problems.
But FeaturesViewer behaviour is really random with a graph editor with multiple related nodes (FeatureExtraction, FeatureMatching, StructureFromMotion).
In the simple graph case (single FeatureExtraction node, single FeatureMatching node, single StructureFromMotion node) everything works fine for me.
gregoire-dl
approved these changes
Feb 1, 2023
mugulmd
force-pushed
the
mug/trackEndpoints
branch
from
5a4e14d to
e9a75c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the "display track endpoints" option in the features viewer.
See alicevision/QtAliceVision#25 for details.