[Features Viewer] Track reconstruction states #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-dl
requested changes
Dec 7, 2022
…ny other track geometry
…es the track line
mugulmd
force-pushed
the
dev/lv/trackReconstructionStages
branch
from
88ac20b to
7db89a9
Compare
|
Retested after rebase on develop with several datasets and camera tracking pipelines, seems to work fine |
gregoire-dl
reviewed
Jan 30, 2023
| QThreadPool::globalInstance()->start(ioRunnable); | ||
| } | ||
|
|
||
| void MFeatures::updateGlobalTrackInfo(MViewFeaturesPerViewPerDesc* viewFeaturesPerViewPerDesc) |
There was a problem hiding this comment.
Note:
Global track information needs a lot of I/O, memory and computation (all features, all tracks, ...).
Currently it's the only way to do it, I think.
Maybe, later on, we can compute & export this global information as an output JSON file of the SfM.
gregoire-dl
approved these changes
Feb 1, 2023
| @@ -328,6 +404,16 @@ const MFeatures::MTrackFeaturesPerTrack* MFeatures::getTrackFeaturesPerTrack(con | |||
| return &(itrDesc->second); | |||
| } | |||
|
|
|||
| void MFeatures::getAllViewIds(std::vector<aliceVision::IndexT>& viewIdsToLoad) | |||
| { | |||
| const aliceVision::sfmData::SfMData& sfmData = _msfmData->rawData(); | |||
There was a problem hiding this comment.
viewIdsToLoad.reserve(viewIdsToLoad.size() + sfmData.getViews().size())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new concepts in tracks visualization for conveying global information on them (i.e not limited to the current time window):
Reconstruction states
This PR introduces 3 reconstruction states for tracks:
These states are visualized with the following visual code:
Start/end point
The start/end points of a track (i.e the track features on the view with minimal/maximal frameId) are visualized with oriented triangles.
This visualization can be toggled on/off using a new QML property called
displayTrackEndpoints.Implementation remarks
Since these concepts need global information on the tracks, it is necessary to load all the features from all the views in the scene, which makes the first loading of the FeaturesViewer longer.
Important
This PR should be merged before alicevision/Meshroom#1838