Use standalone Rollup task (no Gulp) #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
force-pushed
the
rollup-standalone
branch
7 times, most recently
from
e0ed994 to
16c4c00
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
There was a problem hiding this comment.
Looking pretty neat! 🙌🏻 Was surprised to not see a rollup.config.js file popping up to be directly used by the CLI and instead have it in our own tasks. But it does do the job 😄
I think it's been a little overreaching in removing the asset-version task though, the separation of concern by having it on its own was pretty clean.
| ? 'all.mjs' | ||
| : '**/!(*.test).mjs' | ||
| // but for 'dist' and 'public' we only want compiled 'all.js' | ||
| const modulePaths = await getListing(srcPath, isPackage |
colinrotherham
force-pushed
the
rollup-standalone
branch
from
16c4c00 to
1c05ea0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
colinrotherham
force-pushed
the
rollup-standalone
branch
from
1c05ea0 to
abdf26b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
|
@romaricpascal This is ready for review again Split out a couple of unrelated changes: |
domoscargin
reviewed
Dec 19, 2022
colinrotherham
force-pushed
the
rollup-standalone
branch
from
abdf26b to
70d3d9a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
colinrotherham
force-pushed
the
rollup-standalone
branch
from
70d3d9a to
5eb4cbc
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
colinrotherham
force-pushed
the
rollup-standalone
branch
from
5eb4cbc to
94bf08f
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
colinrotherham
force-pushed
the
rollup-standalone
branch
from
94bf08f to
0c25266
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
colinrotherham
force-pushed
the
rollup-standalone
branch
from
0c25266 to
721b159
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
Component JavaScript can be skipped as we also do for ‘dist’
We no longer need to pin `[email protected]` since `gulp-better-rollup` has been removed Changes: rollup/rollup@v0.56.5...v0.59.4
colinrotherham
force-pushed
the
rollup-standalone
branch
from
721b159 to
7765b4a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3088
domoscargin
approved these changes
Dec 20, 2022
This was referenced Feb 7, 2023
colinrotherham
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friday tech debt PR
This PR moves our Rollup
compile:jstask into a separate file but also:Also spotted for local development we were compiling all JavaScript files but only loading
all.jsThat's now faster, plus we can remove some super old packages:
Ticks off some tasks from: