Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version info from package.json to config #3113

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Add version info from package.json to config #3113

merged 2 commits into from
Dec 19, 2022

Conversation

colinrotherham
Copy link
Contributor

Quick PR to split up our configPaths into separate parts:

import { paths, pkg, ports } from './config/index.js'

(Seemed a bit odd that "ports" was inside configPaths.ports)

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3113 December 16, 2022 16:52 Inactive
@colinrotherham colinrotherham mentioned this pull request Dec 16, 2022
Merged
36degrees
36degrees approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍🏻

@colinrotherham colinrotherham merged commit 3e22f84 into main Dec 19, 2022
@colinrotherham colinrotherham deleted the pkg-ports-config branch December 19, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
tech debt
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinrotherham @36degrees @govuk-design-system-ci