This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Configure collections_publisher_db_admin machine class #11353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
commented
Dec 14, 2021
modules/govuk/manifests/node/s_collections_publisher_db_admin.pp
Outdated
Show resolved
Hide resolved
ChrisBAshton
force-pushed
the
collections-publisher-db-admin
branch
from
eb9542b to
9f9be46
Compare
ChrisBAshton
commented
Dec 14, 2021
| @@ -468,6 +468,8 @@ govuk::apps::ckan::s3_aws_secret_access_key: "%{hiera('s3_aws_secret_access_key' | |||
|
|
|||
| govuk::apps::collections::unicorn_worker_processes: 8 | |||
|
|
|||
| # TODO: switch to "collections-publisher-mysql" and uncomment the 'push' | |||
| # `govuk_env_sync::tasks` tasks when we're ready to switch to the dedicated RDS instance | |||
| govuk::apps::collections_publisher::db_hostname: "mysql-primary" | |||
| govuk::apps::collections_publisher::jwt_auth_secret: "%{hiera('jwt_auth_secret')}" | |||
| govuk::apps::collections_publisher::redis_host: "%{hiera('sidekiq_host')}" | |||
There was a problem hiding this comment.
Unlike the PostgreSQL equivalent, we don't need to set a s_collections_publisher_db_admin::apt_mirror_hostname here, as it isn't used anywhere in the govuk::node::s_collections_publisher_db_admin class.
ChrisBAshton
force-pushed
the
collections-publisher-db-admin
branch
from
9f9be46 to
d509c2f
Compare
kevindew
approved these changes
Dec 14, 2021
modules/govuk/manifests/node/s_collections_publisher_db_admin.pp
Outdated
Show resolved
Hide resolved
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
force-pushed
the
collections-publisher-db-admin
branch
from
d509c2f to
d70272b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of RFC-143,
which concludes that every GOV.UK relational database should have
its own RDS instance.
Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances