Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Configure account_api_db_admin machine class #11342

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

ChrisBAshton
Copy link
Contributor

This creates a dedicated database admin machine for the Account
API, following the content_data_api_db_admin convention. This is
in order to facilitate the implementation of RFC-143, which
concludes that every GOV.UK relational database should have its
own RDS instance.

Trello: https://trello.com/c/kMRRFmAh/43-configure-puppet-for-new-db-admin-instances

@ChrisBAshton ChrisBAshton force-pushed the account_api_db_admin branch 2 times, most recently from 4e0cb1d to 351561c Compare December 10, 2021 12:09
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good Chris, just a couple of comments on the push that should be simple to resolve and a thornier one on the env sync script for the transitory phase.

hieradata_aws/class/integration/account_api_db_admin.yaml Outdated Show resolved Hide resolved
hieradata_aws/class/production/account_api_db_admin.yaml Outdated Show resolved Hide resolved
hieradata_aws/class/staging/account_api_db_admin.yaml Outdated Show resolved Hide resolved
hieradata_aws/common.yaml Outdated Show resolved Hide resolved
modules/govuk_env_sync/files/govuk_env_sync.sh Outdated Show resolved Hide resolved
@ChrisBAshton ChrisBAshton force-pushed the account_api_db_admin branch 6 times, most recently from 1df91be to 31e1a4a Compare December 13, 2021 09:32
@kevindew
Copy link
Member

The hieradata config changes look good to me 👍

@ChrisBAshton ChrisBAshton force-pushed the account_api_db_admin branch 2 times, most recently from 204b402 to 4c4216e Compare December 14, 2021 08:51
@ChrisBAshton ChrisBAshton marked this pull request as ready for review December 14, 2021 10:19
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks; just one minor thing

hieradata_aws/class/production/account_api_db_admin.yaml Outdated Show resolved Hide resolved
This creates a dedicated database admin machine for the Account
API, following the content_data_api_db_admin convention. This is
in order to facilitate the implementation of [RFC-143][], which
concludes that every GOV.UK relational database should have its
own RDS instance.

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
@ChrisBAshton ChrisBAshton merged commit 23a78db into main Dec 14, 2021
@ChrisBAshton ChrisBAshton deleted the account_api_db_admin branch December 14, 2021 12:06
ChrisBAshton added a commit that referenced this pull request Dec 14, 2021
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of [RFC-143][],
which concludes that every GOV.UK relational database should have
its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton added a commit that referenced this pull request Dec 14, 2021
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of [RFC-143][],
which concludes that every GOV.UK relational database should have
its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton added a commit that referenced this pull request Dec 14, 2021
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of [RFC-143][],
which concludes that every GOV.UK relational database should have
its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton added a commit that referenced this pull request Dec 14, 2021
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of [RFC-143][],
which concludes that every GOV.UK relational database should have
its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton added a commit that referenced this pull request Dec 14, 2021
This creates a dedicated database admin machine for Collections
Publisher, following the Account API convention devised in #11342.
This is in order to facilitate the implementation of [RFC-143][],
which concludes that every GOV.UK relational database should have
its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Whitehall, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Signon, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Search Admin, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Release, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend added a commit that referenced this pull request Dec 15, 2021
This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants