This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Configure account_api_db_admin machine class #11342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
force-pushed
the
account_api_db_admin
branch
2 times, most recently
from
December 10, 2021 12:09
4e0cb1d
to
351561c
Compare
kevindew
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good Chris, just a couple of comments on the push that should be simple to resolve and a thornier one on the env sync script for the transitory phase.
ChrisBAshton
force-pushed
the
account_api_db_admin
branch
6 times, most recently
from
December 13, 2021 09:32
1df91be
to
31e1a4a
Compare
The hieradata config changes look good to me 👍 |
ChrisBAshton
force-pushed
the
account_api_db_admin
branch
2 times, most recently
from
December 14, 2021 08:51
204b402
to
4c4216e
Compare
ChrisBAshton
force-pushed
the
account_api_db_admin
branch
from
December 14, 2021 10:25
4c4216e
to
e2a3e42
Compare
kevindew
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks; just one minor thing
This creates a dedicated database admin machine for the Account API, following the content_data_api_db_admin convention. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
force-pushed
the
account_api_db_admin
branch
from
December 14, 2021 10:32
e2a3e42
to
10871f2
Compare
ChrisBAshton
added a commit
that referenced
this pull request
Dec 14, 2021
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
added a commit
that referenced
this pull request
Dec 14, 2021
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
added a commit
that referenced
this pull request
Dec 14, 2021
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
added a commit
that referenced
this pull request
Dec 14, 2021
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ChrisBAshton
added a commit
that referenced
this pull request
Dec 14, 2021
This creates a dedicated database admin machine for Collections Publisher, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Whitehall, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Signon, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Search Admin, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Release, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
ollietreend
added a commit
that referenced
this pull request
Dec 15, 2021
This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342. This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance. Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances [RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a dedicated database admin machine for the Account
API, following the content_data_api_db_admin convention. This is
in order to facilitate the implementation of RFC-143, which
concludes that every GOV.UK relational database should have its
own RDS instance.
Trello: https://trello.com/c/kMRRFmAh/43-configure-puppet-for-new-db-admin-instances