Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Configure contacts_admin_db_admin machine class #11360

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

ollietreend
Copy link
Contributor

This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of RFC-143, which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

contacts vs contacts-admin

For historial reasons, the name of this app is inconsistent. It's usually called contacts-admin nowadays, but in a past life it was known as contacts. There's still some old Puppet config lingering which still calls it that.

I've used the name contacts-admin on everything that's new, but have stopped short of renaming existing things.

This creates a dedicated database admin machine for Contacts Admin, following the Account API convention devised in #11342.

This is in order to facilitate the implementation of [RFC-143][], which concludes that every GOV.UK relational database should have its own RDS instance.

Trello: https://trello.com/c/HjK4AbUS/49-configure-puppet-for-new-db-admin-mysql-instances

[RFC-143]: https://github.com/alphagov/govuk-rfcs/blob/main/rfc-143-split-database-instances.md
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍 Thanks!

@@ -1,6 +1,6 @@
# == Class: govuk::apps:contacts:db
#
# MySQL to store content for the Contacts app
# MySQL to store content for the Contacts Admin app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ollietreend ollietreend merged commit 2609a6c into main Dec 15, 2021
@ollietreend ollietreend deleted the contacts_admin_db_admin branch December 15, 2021 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants