Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "extra links" within image_card #2295

Closed
chris-gds opened this issue Sep 7, 2021 · 0 comments · Fixed by #2300
Closed

Rename "extra links" within image_card #2295

chris-gds opened this issue Sep 7, 2021 · 0 comments · Fixed by #2300
Labels
good first issue technical debt

Comments

@chris-gds
Copy link
Contributor

chris-gds commented Sep 7, 2021 •
edited
Loading

What

During this PR a less-than-ideal name extra_links_with_links was chosen

Suggestion

Changing this name to something like extra_list and extra_list_with_links

extra_list
extra_list_with_links

As well updating the gem, an update is needed on the repos where it is used (to keep any changes in sync) - initial search reveals use mainly on collections

https://github.com/search?l=Ruby&q=org%3Aalphagov+extra_links&type=Code
https://github.com/search?l=HTML%2BERB&q=org%3Aalphagov+extra_links&type=Code
@chris-gds chris-gds changed the title Rename "image_card" Rename "extra links" within image_card Sep 7, 2021
chris-gds pushed a commit that referenced this issue Sep 8, 2021
Resolves #2295
90eaf06 
extra_links to extra_list

An additional - no link option was added to extra_links making it confusing in terms of the naming, consider "extra_links_no_links" this has been updated to "list" so it makes more sense - "extra_list_no_links"
@chris-gds chris-gds mentioned this issue Sep 8, 2021
Merged
chris-gds pushed a commit that referenced this issue Sep 9, 2021
Resolves #2295
45d565e 
- Rename extra_links to extra_details

An additional - no link option was added to extra_links making it confusing in terms of the naming, consider "extra_links_no_links" this has been updated to "extra_details" so it makes more sense - "extra_details_no_links" 

- Update CHANGELOG
hannako added a commit to alphagov/collections that referenced this issue Sep 23, 2021
@hannako
Update a deprecated attribute name
fda44ac 
ref: alphagov/govuk_publishing_components#2295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename "extra links" within image_card alphagov/govuk_publishing_components
1 participant
@chris-gds