Add text list to image card #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
chris-gds
force-pushed
the
change-extra-links
branch
from
bf0bf44 to
4b4d158
Compare
andysellick
approved these changes
Aug 26, 2021
app/views/govuk_publishing_components/components/docs/image_card.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_image_card.html.erb
Outdated
Show resolved
Hide resolved
Should a link not be provided to the "extra_links" property then it will fallback to a text list that uses the secondary grey text colour.
chris-gds
force-pushed
the
change-extra-links
branch
from
4b4d158 to
9b93cc8
Compare
Merged
This was referenced Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Should links within
extra_linksnot be provided to theimage_cardthis will then fallback to render a text element list in grey (secondary text colour)Why
As part of this PR the Design uses an
image_cardhowever this particular visual does not exist within the context of theimage_cardcomponent. This update extends theimage_cardto provide additional variations to accommodate this new visualConsider this Design:
Visual Changes
Additional option visual: