Add a form attribute to the button component
#4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
approved these changes
Jan 29, 2025
app/views/govuk_publishing_components/components/docs/button.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/button.yml
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/button.yml
Outdated
Show resolved
Hide resolved
This allows us to have a button outside a containing form element (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#form) This is useful if we want to have two buttons in a form group next to one another inside a form group (for example if one form action submits the form and the other button submits to a form to delete the item that is being edited)
pezholio
force-pushed
the
add-form-attribute-to-button-component
branch
from
7dafe33 to
d3f7eb6
Compare
pezholio
added a commit
that referenced
this pull request
Jan 30, 2025
pezholio
added a commit
that referenced
this pull request
Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have a button outside a containing form element (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#form) This is useful if we want to have two buttons in a form group next to one another inside a form group (for example if one form action submits the form and the other button submits to a form to delete the item that is being edited)