Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to LUX 4.0.29 #4597

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Update to LUX 4.0.29 #4597

merged 1 commit into from
Jan 30, 2025

Conversation

andysellick
Copy link
Contributor

@andysellick andysellick commented Jan 30, 2025

What

Update to LUX 4.0.29, following the instructions here: https://github.com/alphagov/govuk_publishing_components/blob/main/docs/real-user-metrics.md#how-to-update-to-a-new-version

I've tested this using the LUX debugging tool but strangely it reports a version number of 4.0.28 (the previous version) so not sure what's going on there.

Why

We need to update to the latest version or this code will stop working.

Visual Changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4597 January 30, 2025 09:22 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4597 January 30, 2025 09:24 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4597 January 30, 2025 09:31 Inactive
@andysellick andysellick marked this pull request as ready for review January 30, 2025 09:34
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4597 January 30, 2025 09:35 Inactive
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve this as it seems to be just a dependency update

@andysellick andysellick requested a review from AshGDS January 30, 2025 10:37
@andysellick andysellick merged commit bc1f13b into main Jan 30, 2025
12 checks passed
@andysellick andysellick deleted the lux-4.0.29 branch January 30, 2025 10:50
pezholio added a commit that referenced this pull request Jan 30, 2025
* Update to LUX 4.0.29 ([PR #4597](#4597))
* Add a `form` attribute to the button component ([PR #4588](#4588))
pezholio added a commit that referenced this pull request Jan 30, 2025
* Update to LUX 4.0.29 ([PR #4597](#4597))
* Add a `form` attribute to the button component ([PR #4588](#4588))
@pezholio pezholio mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants