Update past prime ministers #6236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
force-pushed
the
update-past-prime-minister
branch
2 times, most recently
from
7aef397 to
e4e059a
Compare
chris-gds
force-pushed
the
update-past-prime-minister
branch
4 times, most recently
from
7fb92d3 to
8b0f4cb
Compare
chris-gds
requested review from
injms and
danacotoran
and removed request for
injms
chris-gds
force-pushed
the
update-past-prime-minister
branch
2 times, most recently
from
a5716f1 to
d50a235
Compare
chris-gds
force-pushed
the
update-past-prime-minister
branch
4 times, most recently
from
5799412 to
d804e48
Compare
chris-gds
requested review from
jon-kirwan
and removed request for
danacotoran,
injms and
owenatgov
This was referenced Aug 20, 2021
Closed
|
Looks fine to me - although it looks there is one error with one of the tests (otherwise all good!) |
chris-gds
force-pushed
the
update-past-prime-minister
branch
2 times, most recently
from
fb6c70b to
1589989
Compare
injms
reviewed
Aug 24, 2021
maxgds
reviewed
Aug 25, 2021
chris-gds
force-pushed
the
update-past-prime-minister
branch
2 times, most recently
from
74c0aef to
889148a
Compare
edwardkerry
force-pushed
the
update-past-prime-minister
branch
2 times, most recently
from
c0b347e to
7cbffb1
Compare
chris-gds
force-pushed
the
update-past-prime-minister
branch
from
a24ea0d to
d48b5f6
Compare
|
Testing issues, currently, believed not be related |
maxgds
approved these changes
Sep 1, 2021
@chris-gds Before we merge this could you rebase against master and push to integration to ensure the gem change is being picked up as we'd expect? |
- Remove Duplicate Header - Update to use image card component[1] - Restructure groupings of people into 21st, 20th + 18/19th Centuries. - Apply Design system - Restructure render so grouping is via column-quarters / grid system[2] - Add breadcrumb link due to current IA of site. "The breadcrumb should start with your ‘home’ page and end with the parent section of the current page."[3] Page: /government/history/past-prime-ministers [1] https://components.publishing.service.gov.uk/component-guide/image_card [2] https://design-system.service.gov.uk/styles/layout/ [3] https://design-system.service.gov.uk/components/breadcrumbs/
- Update with ID as Whitehall testing requires require res unique ID on element - Update to use image coming from database (placeholder used for local dev) PR a
To match Design[1] - Add spacing between sections on larger screens - Overwrite image card styling for "years of service" Content [1]https://www.figma.com/file/UjCeRTxle1bLQv3VFNz9Wt/Redesign-of-history-pages?node-id=11%3A138
…ntries Previously individuals who had held the same appointment multiple times would appear in the list for each occurance. This change ensures that only the most recent appointment is displayed, with the past apppointment dates listed for the same entry.
Integrate "extra_links" from updated image_card changes so item displays: [party] [year] [party] [year] [party] [year] as text only.
chris-gds
force-pushed
the
update-past-prime-minister
branch
from
d48b5f6 to
d923291
Compare
Course, as merged integration - looks as expected, will just be sharing with Design before merging |
|
|
Merged
|
Moving into draft as combined PR raised: #6264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update Past Prime Minster's page to apply new Design + Design system + use Components
Why
On-going work to align architecture, have pages benefit from Accessibility improvements
Visuals
Anything else
image_cardwas extended to factor in a new Design andimage_cardas this maintains existing performance benefits.Discussion around Design System layout + lists can be found here, an issue capturing the concerns can be found here
Grouped related PRs
#6236
#6243
#6241
Done when
loading="lazy"to image card withingovuk_publishing_gemPR: Add lazy loading govuk_publishing_components#2270
loading="lazy"updateimage_cardto give more options to match DesignPR: Add text list to image card govuk_publishing_components#2286