Replace title component with heading #9835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
force-pushed
the
use-heading
branch
3 times, most recently
from
0045be6 to
b4ba5fd
Compare
- replaces one instance of the title component with the heading component - this instance was using `margin_top: 0` which is an option we're removing from the title component - instead use the heading component, which when configured like this should look exactly like the title component, but by default has no margin top - in some circumstances (i.e. bazillions of tests) the heading component in this page gets passed `nil` for margin_bottom, which the heading component reacts badly to by throwing an error, hence why the options are declared ahead of the call to the heading component - hopefully therefore no visual changes
andysellick
force-pushed
the
use-heading
branch
from
b4ba5fd to
acf55da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / why
margin_top: 0which is an option we're removing from the title componentRelated to this change: alphagov/govuk_publishing_components#4508
Trello card: https://trello.com/c/Y0pDWbHw/390-move-some-shared-helper-options-into-component-wrapper