Add margin_bottom to heading_options #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The title component includes a margin bottom by default and therefore I’ve added some margin_bottom to the heading options. I believe this should be okay because even though passing nil for the bottom margin was an option previously, this didn’t mean any margin was removed - rather it fell back to the default bottom margin of the title component. In other words, adding some bottom margin here for every instance shouldn’t cause any issues as I don’t believe there is a scenario where the heading will have no bottom margin.
AshGDS
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
This PR amends the
margin_bottomoption for the main heading to always include a bottom margin. Previously, this would be set toniliftitle_margin_bottomwasn't present however this didn't remove the bottom margin - rather it fell back to the title component's default bottom margin of 50px. Since the heading component doesn't include a default bottom margin, switching to this component resulted in removing the spacing beneath the main heading altogether. This PR reinstates it.Why
To reinstate the original spacing.
Visual changes
Spacing below the main heading has been reinstated.