fix: Remove css contenthash due to no effect if using random values #634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tamika Tannis [email protected]
Summary of Changes
We have observed that the
contenthash
for the css files are different each time the same commit is built, due to the use ofrandom
in some of our shimmer styles.As a result the content is different each time, which negates the benefits of using hashes. If merged, we still have the option of revisiting this to reconsider the use of
random
in our styles in order to reintroduce content hashing on the css files.Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.