Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove css contenthash due to no effect if using random values #634

Closed
wants to merge 1 commit into from

Conversation

ttannis
Copy link
Contributor

@ttannis ttannis commented Sep 1, 2020

Signed-off-by: Tamika Tannis [email protected]

Summary of Changes

We have observed that the contenthash for the css files are different each time the same commit is built, due to the use of random in some of our shimmer styles.

As a result the content is different each time, which negates the benefits of using hashes. If merged, we still have the option of revisiting this to reconsider the use of random in our styles in order to reintroduce content hashing on the css files.

Tests

N/A

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@ttannis ttannis changed the title fix: Remove css contenthash due to no effect if using fix: Remove css contenthash due to no effect if using random values Sep 1, 2020
@ttannis
Copy link
Contributor Author

ttannis commented Sep 1, 2020

Closing in favor of #635

@ttannis ttannis closed this Sep 1, 2020
@ttannis ttannis deleted the ttannis_remove-css-contenthash branch September 1, 2020 21:59
@ttannis ttannis restored the ttannis_remove-css-contenthash branch September 1, 2020 21:59
@ttannis ttannis deleted the ttannis_remove-css-contenthash branch September 1, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant