Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove randomized css widths #635

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

ttannis
Copy link
Contributor

@ttannis ttannis commented Sep 1, 2020

Summary of Changes

Using randomized widths negates the effects of css content hashing, as the built content will be different each time due to the random widths. This PR removes those usages, and for now I have just chosen 75% for widths that need a percentage, and splitting the different between the old max width and min width for others.

Tests

N/A but confirmed the build returns the same contenthash each time.

Documentation

N/A

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@@ -4,7 +4,7 @@
$shimmer-loader-items: 1, 2, 3, 4, 5;
$shimmer-loader-row-height: 16px;
$shimmer-loader-row-min-width: 90;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could remove this one too

Copy link
Contributor Author

@ttannis ttannis Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$shimmer-loader-row-min-width still used on line 79 for now, do you want to remove that too?

Golodhros
Golodhros previously approved these changes Sep 1, 2020
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tamika Tannis <[email protected]>
@ttannis ttannis dismissed stale reviews from Golodhros and dikshathakur3119 via ab0464f September 1, 2020 22:19
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttannis ttannis merged commit 5068b3e into master Sep 1, 2020
@ttannis ttannis deleted the ttannis_remove-randomized-css-widths branch September 9, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants