feat: Add resource_reports field in Table API ( Atlas proxy) #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port in table model)
verdan
requested changes
Jul 14, 2020
| @@ -377,6 +402,8 @@ def get_table(self, *, table_uri: str) -> Table: | |||
|
|
|||
| columns = self._serialize_columns(entity=entity) | |||
|
|
|||
| reports_guids = [report.get("guid") for report in attrs.get("reports") or list()] | |||
There was a problem hiding this comment.
@dechoma is it possible to filter out the active reports here already ? I think you'll have the active status available here, so no need to make a query with the inactive queries.
There was a problem hiding this comment.
Unfortunately, attributes contain only report typeName and guid{'owner': 'testuser', 'temporary': False, 'reports': [{'guid': '50160c85-cdd1-4bac-800a-9bb623b816d1', 'typeName': 'Report'}], ...() }
# Conflicts: # metadata_service/proxy/atlas_proxy.py # tests/unit/proxy/fixtures/atlas_test_data.py # tests/unit/proxy/test_atlas_proxy.py
mgorsk1
reviewed
Jul 17, 2020
|
LGTM (just one nit) wdyt @verdan ? |
# Conflicts: # metadata_service/proxy/atlas_proxy.py # tests/unit/proxy/fixtures/atlas_test_data.py # tests/unit/proxy/test_atlas_proxy.py
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 73.25% 73.35% +0.10%
==========================================
Files 26 26
Lines 1249 1265 +16
Branches 132 136 +4
==========================================
+ Hits 915 928 +13
- Misses 307 309 +2
- Partials 27 28 +1
Continue to review full report at Codecov.
|
|
cc @verdan |
feng-tao
approved these changes
Jul 21, 2020
|
I will update the version later actually. Thanks for the pr and review :) |
jerryzhu2007
pushed a commit
to kylg/amundsenmetadatalibrary
that referenced
this pull request
Aug 20, 2020
* commit '369685cc715e95af82dfa4dc14d0c58af8bb1ac9': chore: replace references to Lyft -> Amundsen (amundsen-io#174) feat: Data Owner Implementation of Atlas Proxy (amundsen-io#156) chore: fix docker push action (amundsen-io#172) chore: add docker publish action and remove travis (amundsen-io#171) chore: add pypi publish action (amundsen-io#170) fix: removing OidcConfig file and making statsd configurable through envrionment variable (amundsen-io#157) ci: add dependabot config (amundsen-io#169) Update repo name in travis file (amundsen-io#163) feat: Populate is_view property in AtlasProxy (amundsen-io#155) fix: Overlapping table name issue in Readers [AtlasProxy] feat: Add resource_reports field in Table API ( Atlas proxy) (amundsen-io#149) chore: apply license headers to all the source files (amundsen-io#153) feat: Add programmatic descriptions parser for [AtlasProxy] (amundsen-io#152) feat: Add Frequent Users feature in [AtlasProxy] (amundsen-io#147) feat: Implement configurable minimum number of readers for popular tables (amundsen-io#146) chore: update the email for the project (amundsen-io#148) # Conflicts: # README.md # docs/configurations.md # docs/structure.md # metadata_service/config.py # metadata_service/oidc_config.py # metadata_service/proxy/neo4j_proxy.py # requirements.txt # setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add resource_reports field in Table API ( atlas proxy) to support integration with tools generating static HTML reports, such as popmon, pandas-profiling or great_expectations..
Tests
Updated existing unit tests
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.
make testResolve amundsen-io/amundsen#525