-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Data Owner Implementation of Atlas Proxy #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits
72573ab
to
b8a3fc2
Compare
6b2a9c8
to
2d8ad8d
Compare
Signed-off-by: verdan <[email protected]> Updates Signed-off-by: verdan <[email protected]> Refactoring - Code Reviews Signed-off-by: verdan <[email protected]> Refactoring Signed-off-by: verdan <[email protected]> Updates the test cases, based on owner changes Signed-off-by: verdan <[email protected]> Updates the lambda function definition Signed-off-by: verdan <[email protected]>
2d8ad8d
to
7b6c893
Compare
@feng-tao @jinhyukchang @mgorsk1 can you please review this PR? |
will leave it to @mgorsk1 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, otherwise lgtm
Signed-off-by: verdan <[email protected]>
e87a0a0
to
8519594
Compare
@feng-tao good to merge this ? |
* commit '369685cc715e95af82dfa4dc14d0c58af8bb1ac9': chore: replace references to Lyft -> Amundsen (amundsen-io#174) feat: Data Owner Implementation of Atlas Proxy (amundsen-io#156) chore: fix docker push action (amundsen-io#172) chore: add docker publish action and remove travis (amundsen-io#171) chore: add pypi publish action (amundsen-io#170) fix: removing OidcConfig file and making statsd configurable through envrionment variable (amundsen-io#157) ci: add dependabot config (amundsen-io#169) Update repo name in travis file (amundsen-io#163) feat: Populate is_view property in AtlasProxy (amundsen-io#155) fix: Overlapping table name issue in Readers [AtlasProxy] feat: Add resource_reports field in Table API ( Atlas proxy) (amundsen-io#149) chore: apply license headers to all the source files (amundsen-io#153) feat: Add programmatic descriptions parser for [AtlasProxy] (amundsen-io#152) feat: Add Frequent Users feature in [AtlasProxy] (amundsen-io#147) feat: Implement configurable minimum number of readers for popular tables (amundsen-io#146) chore: update the email for the project (amundsen-io#148) # Conflicts: # README.md # docs/configurations.md # docs/structure.md # metadata_service/config.py # metadata_service/oidc_config.py # metadata_service/proxy/neo4j_proxy.py # requirements.txt # setup.py
Summary of Changes
Include a summary of changes then remove this line
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test