feat: Making include accept an array of globs, like source does #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__tests__/extend.test.js
Outdated
| expect(StyleDictionaryExtended.properties).toEqual(helpers.fileToJSON(__dirname + "/__properties/paddings.json")); | ||
| }); | ||
|
|
||
| it('should override existing properties include is given', () => { |
There was a problem hiding this comment.
Not my native language but is this description correct?
There was a problem hiding this comment.
Good catch, looks like it is missing 'if' in between 'properties' and 'include'.
__tests__/extend.test.js
Outdated
| expect( | ||
| StyleDictionary.extend.bind(null, {include: ['foo']}) | ||
| ).toThrow("Cannot find module 'foo'"); | ||
| it('should not update properties if sourche glob paths dont resolve to anything', () => { |
There was a problem hiding this comment.
typos in sourche and dont
|
LGTM |
dbanksdesign
added a commit
that referenced
this pull request
Feb 5, 2019
* feat: add registerFilter method (#233) * doc: remove registerTemplate from examples (#232) * feat: add node example (#228) * feat: making include accept an array of globs, like source does (#227) * fix: the naming for Sass/Scss in documentation, tests, formats, fixes #213 (#222) * fix: handle showFileHeader option in androids formats templates, fixes #237 (#243)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #215
Description of changes: Changing the behavior of
includeattribute on the config to match the behavior ofsource. Nowincludeaccepts an array of path globs, instead of just file paths. This change should be a superset change, as normal file paths still function the same.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.