Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move configurations to package.json #33

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: move configurations to package.json #33

merged 1 commit into from
Apr 28, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented Apr 13, 2023

References

Similar to jupyter-server/jupyter-resource-usage#188 and jupyter-server/jupyter_server#1246

Code changes

Changes proposed by this PR can be summarised as follows :-

  • Move the content from .eslintrc.json under the eslintConfig key in package.json. Source(eslint docs)

Doing so, would lead to a more minimal project structure without any functional change.

@SauravMaheshkar
Copy link
Contributor Author

Request for Review: @mattkram

@dbast
Copy link
Member

dbast commented Apr 25, 2023

@SauravMaheshkar The renovate site states Storing the Renovate configuration in a package.json file is deprecated and support may be removed in the future.... so to be kept outside as renovate.json as separate file.

@SauravMaheshkar
Copy link
Contributor Author

Addressed in a485ba5

@dbast dbast merged commit d811358 into anaconda:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants