Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move babel and eslint configuration under package.json #1246

Merged
merged 2 commits into from
Mar 27, 2023
Merged

chore: move babel and eslint configuration under package.json #1246

merged 2 commits into from
Mar 27, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

Changes proposed by this PR can be summarised as follows :-

  • Move the content from .babelrc under the babel key in package.json. Source(babel docs)
  • Move the content from .eslintrc.json under the eslintConfig key in package.json. Source(eslint docs)
  • Move the content from .eslintignore under the eslintIgnore key in package.json. Source(eslint docs)

Doing so, would lead to a more minimal project structure without any functional change.

@welcome
Copy link

welcome bot commented Mar 26, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (702c248) 80.39% compared to head (acc9b62) 80.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
- Coverage   80.39%   80.25%   -0.15%     
==========================================
  Files          68       68              
  Lines        8264     8264              
  Branches     1600     1600              
==========================================
- Hits         6644     6632      -12     
- Misses       1198     1206       +8     
- Partials      422      426       +4     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 496d307 into jupyter-server:main Mar 27, 2023
@welcome
Copy link

welcome bot commented Mar 27, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants