fix: go version not properly identified in binary #1384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an issue identifying the version string in go binaries. The binary may contain many matching
go#.#
patterns, for example in help text strings that may be presented to the user. These may occur before the actual version string. This PR attempts to find the correct version string by searching for<pattern><NULL>
, which upon inspecting the go binary seems to be one of the only ways to identify it.This PR also corrects a missing
FoundBy
field as well as the CPE used for the Go binary.Fixes #1382
FWIW I've run this on my local macOS go binary, as well as the latest docker images through
1.16
: