Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SPDX license list to 3.19 #1389

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Update SPDX license list to 3.19 #1389

merged 4 commits into from
Dec 8, 2022

Conversation

vargenau
Copy link
Contributor

@vargenau vargenau commented Dec 7, 2022

Signed-off-by: Marc-Etienne Vargenau [email protected]

Signed-off-by: Marc-Etienne Vargenau <[email protected]>
@vargenau
Copy link
Contributor Author

vargenau commented Dec 7, 2022

I see no relation between the unit test failing and my commit?

@kzantow
Copy link
Contributor

kzantow commented Dec 7, 2022

@vargenau one of the failing tests is related: https://github.com/anchore/syft/actions/runs/3638750705/jobs/6141321711#step:14:97 (the other one does not look related). Did you update this list using make generate-license-list? If not, this test will continue to fail as it is comparing the results from make generate-license-list to the file.

@vargenau
Copy link
Contributor Author

vargenau commented Dec 7, 2022

Thank you @kzantow

I have fixed the test related to my commit. In fact, I had to include the new licenses added by 3.19 in generate_license_list_test.go, it was not an issue with make generate-license-list.

The other test that is unrelated is still failing. Can you please have a look?

@kzantow
Copy link
Contributor

kzantow commented Dec 7, 2022

@vargenau yes, I'm having a look at the failing test now -- it looks like it's not exclusive to this PR, either. Stay tuned.

@kzantow
Copy link
Contributor

kzantow commented Dec 7, 2022

@vargenau looks like this is dependent on: #1393 -- will re-run tests & such when it's merged

@vargenau
Copy link
Contributor Author

vargenau commented Dec 8, 2022

Thank you @kzantow

@vargenau
Copy link
Contributor Author

vargenau commented Dec 8, 2022

@kzantow
All checks have passed now, thank you for fixing this.

@kzantow kzantow merged commit 13ceed9 into anchore:main Dec 8, 2022
spiffcs added a commit to raboof/syft that referenced this pull request Dec 20, 2022
* main: (87 commits)
  feat: Add license parsing for java (anchore#1385)
  fix: cyclonedx component type for binaries (anchore#1406)
  fix: openjdk detection pattern (anchore#1415)
  bug: spdx checksum empty array; allow syft to generate SHA1 for spdx-tag-value documents (anchore#1404)
  Add NetBSD support. (anchore#1412)
  feat: add catalog delete (anchore#1377)
  docs: remove file classifier (anchore#1397)
  chore: update latest cyclonedx library (anchore#1390)
  feat: Add Java binary catalogers (anchore#1392)
  chore: Update SPDX license list to 3.19 (anchore#1389)
  fix: add manual vendor/product removal to fix false flags (anchore#1070)
  Update Stereoscope to c5ff155d72f166e2332e160a75c3ff2b8e9c7e2e (anchore#1395)
  chore: fix test busybox image sha (anchore#1393)
  fix: go version not properly identified in binary (anchore#1384)
  Update Stereoscope to 3b80d983223f6e6fc2d33b0ffa003d30268418e9 (anchore#1376)
  fix: Update node binary package name (anchore#1375)
  feat: Generic Binary Cataloger (anchore#1336)
  recover from bad parsing of golang binary (anchore#1371)
  Fix parsing of apk databases with large entries (anchore#1365)
  Update syft bootstrap tools to latest versions. (anchore#1369)
  ...
spiffcs added a commit to cpendery/syft that referenced this pull request Dec 20, 2022
* main: (189 commits)
  feat: add h1digest when scanning go.mod (anchore#1405)
  feat: Add license parsing for java (anchore#1385)
  fix: cyclonedx component type for binaries (anchore#1406)
  fix: openjdk detection pattern (anchore#1415)
  bug: spdx checksum empty array; allow syft to generate SHA1 for spdx-tag-value documents (anchore#1404)
  Add NetBSD support. (anchore#1412)
  feat: add catalog delete (anchore#1377)
  docs: remove file classifier (anchore#1397)
  chore: update latest cyclonedx library (anchore#1390)
  feat: Add Java binary catalogers (anchore#1392)
  chore: Update SPDX license list to 3.19 (anchore#1389)
  fix: add manual vendor/product removal to fix false flags (anchore#1070)
  Update Stereoscope to c5ff155d72f166e2332e160a75c3ff2b8e9c7e2e (anchore#1395)
  chore: fix test busybox image sha (anchore#1393)
  fix: go version not properly identified in binary (anchore#1384)
  Update Stereoscope to 3b80d983223f6e6fc2d33b0ffa003d30268418e9 (anchore#1376)
  fix: Update node binary package name (anchore#1375)
  feat: Generic Binary Cataloger (anchore#1336)
  recover from bad parsing of golang binary (anchore#1371)
  Fix parsing of apk databases with large entries (anchore#1365)
  ...
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants