Address review comments

spyder/api/plugin_registration/confpage.py → spyder/api/plugin_registration/_confpage.py

@@ -4,17 +4,17 @@
 # Licensed under the terms of the MIT License
 # (see spyder/__init__.py for details)
 
-"""Spyder completion plugin configuration page."""
+"""Plugin registry configuration page."""
 
 # Third party imports
 from qtpy.QtWidgets import (QGroupBox, QVBoxLayout, QCheckBox,
                             QGridLayout, QLabel)
 
 # Local imports
+from spyder.api.plugins import SpyderPlugin
+from spyder.api.preferences import PluginConfigPage
 from spyder.config.base import _
 from spyder.config.manager import CONF
-from spyder.api.preferences import PluginConfigPage
-from spyder.api.plugins import SpyderPlugin
 
 
 class PluginsConfigPage(PluginConfigPage):
@@ -23,10 +23,10 @@ def setup_page(self):
         self.plugins_checkboxes = {}
 
         header_label = QLabel(
-            _("Spyder can run with a reduced number of internal and external "
-              "plugins in order to provide a lighter experience. Any plugin "
-              "unchecked in this page will be unloaded immediately and will "
-              "not be loaded next time Spyder starts."))
+            _("Here you can turn on/off any internal or external Spyder plugin "
+              "to disable functionality that is not desired or to have a lighter "
+              "experience. Unchecked plugins in this page will be unloaded "
+              "immediately and will not be loaded the next time Spyder starts."))
         header_label.setWordWrap(True)
 
         # ------------------ Internal plugin status group ---------------------

spyder/api/plugin_registration/registry.py

@@ -8,7 +8,7 @@
 
 # Standard library imports
 import logging
-from typing import Dict, List, Union, Type, Any, Set, Optional
+from typing import Dict, List, Union, Type, Any, Set, Optional, Tuple
 
 # Third-party library imports
 from qtpy.QtCore import QObject, Signal
@@ -18,7 +18,7 @@
 from spyder.config.base import _, running_under_pytest
 from spyder.config.manager import CONF
 from spyder.api.config.mixins import SpyderConfigurationAccessor
-from spyder.api.plugin_registration.confpage import PluginsConfigPage
+from spyder.api.plugin_registration._confpage import PluginsConfigPage
 from spyder.api.plugins.enum import Plugins
 from spyder.api.exceptions import SpyderAPIError
 from spyder.api.plugins import (
@@ -90,6 +90,7 @@ def __init__(self):
         super().__init__()
         PreferencesAdapter.__init__(self)
 
+        # Reference to the main window
         self.main = None
 
         # Dictionary that maps a plugin name to a list of the plugin names
@@ -208,10 +209,9 @@ def _instantiate_spyder5_plugin(
                 module = PluginClass._spyder_module_name
                 package_name = PluginClass._spyder_package_name
                 version = PluginClass._spyder_version
-                description = instance.get_description()
+                description = plugin_instance.get_description()
                 dependencies.add(module, package_name, description,
-                                    version, None,
-                                    kind=dependencies.PLUGIN)
+                                 version, None, kind=dependencies.PLUGIN)
 
         return plugin_instance
 

spyder/api/preferences.py

@@ -129,6 +129,8 @@ def aggregate_sections_partials(self, opts):
         to_update = {}
         for opt in opts:
             if isinstance(opt, tuple):
+                # This is necessary to filter tuple options that do not
+                # belong to a section.
                 if len(opt) == 2 and opt[0] is None:
                     opt = opt[1]
 

spyder/app/mainwindow.py

@@ -909,15 +909,6 @@ def setup(self):
                 try:
                     plugin_instance = PLUGIN_REGISTRY.register_plugin(
                         self, PluginClass, external=True)
-
-                    # These attributes come from spyder.app.find_plugins to
-                    # add plugins to the dependencies dialog
-                    module = PluginClass._spyder_module_name
-                    package_name = PluginClass._spyder_package_name
-                    version = PluginClass._spyder_version
-                    description = plugin_instance.get_description()
-                    dependencies.add(module, package_name, description,
-                                     version, None, kind=dependencies.PLUGIN)
                 except Exception as error:
                     print("%s: %s" % (PluginClass, str(error)), file=STDERR)
                     traceback.print_exc(file=STDERR)

spyder/plugins/editor/plugin.py

@@ -419,7 +419,7 @@ def _rpc_call(self, method, args, kwargs):
     @staticmethod
     def get_plugin_title():
         """Return widget title"""
-        # TODO: This is a temporary measure to get the title of the plugins
+        # TODO: This is a temporary measure to get the title of this plugin
         # without creating an instance
         title = _('Editor')
         return title

spyder/plugins/ipythonconsole/plugin.py

@@ -523,7 +523,7 @@ def toggle_view(self, checked):
     @staticmethod
     def get_plugin_title():
         """Return widget title"""
-        # TODO: This is a temporary measure to get the title of the plugins
+        # TODO: This is a temporary measure to get the title of this plugin
         # without creating an instance
         return _('IPython console')